SysRandom.NextSigned()

[skyoxZ]

machinelearning/src/Microsoft.ML.Core/Utilities/Random.cs

Line 154 in 436700a

return _rnd.Next(int.MinValue, int.MinValue);

Should be return _rnd.Next(int.MinValue, int.MaxValue);

[TomFinley]

Oh that is nasty. Thanks @skyoxZ .

Fortunately, at least in this codebase, it's used in exactly one place:

machinelearning/src/Microsoft.ML.Data/Transforms/ShuffleTransform.cs

Line 99 in c023727

_forceShuffleSeed = args.ForceShuffleSeed ?? Host.Rand.NextSigned();

That is, it derive a random seed for some other PRNG. If I think about how that class is used the effects will be limited, but we should definitely fix it.

[mikaelm12]

Seems like this issue has been resolved here: c5d168d

[Ivanidzo4ka]

Address in PR #172