Skip to content

Final public API for predictor classes #1698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Zruty0 opened this issue Nov 21, 2018 · 1 comment
Closed

Final public API for predictor classes #1698

Zruty0 opened this issue Nov 21, 2018 · 1 comment
Assignees

Comments

@Zruty0
Copy link
Contributor

Zruty0 commented Nov 21, 2018

  1. All predictor classes should be named SoAndSoModelParameters (like KMeansModelParameters, LinearBinaryModelParameters etc.

  2. Strive to remove unnecessary interfaces from the public API: thinks like IPredictor, IPredictorProducing<float> etc. should not be public.

  3. Review the public surface of ModelParameters to enable ONLY parameter introspection. For example:

  • KMeans should only expose centroid coordinates.
  • Linear should only expose weights/biases.
  1. If possible, try to add public constructors. For example:
  • Make it possible to create KMeansModelParameters from centroid coordinates
  • Make it possible to create LinearBinaryModelParameters from weights and biases
@glebuk
Copy link
Contributor

glebuk commented Jan 7, 2019

@sfilipi ensure that it's all done and close.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants