We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All predictor classes should be named SoAndSoModelParameters (like KMeansModelParameters, LinearBinaryModelParameters etc.
SoAndSoModelParameters
KMeansModelParameters
LinearBinaryModelParameters
Strive to remove unnecessary interfaces from the public API: thinks like IPredictor, IPredictorProducing<float> etc. should not be public.
IPredictor
IPredictorProducing<float>
Review the public surface of ModelParameters to enable ONLY parameter introspection. For example:
ModelParameters
KMeans
Linear
The text was updated successfully, but these errors were encountered:
@sfilipi ensure that it's all done and close.
Sorry, something went wrong.
najeeb-kazmi
No branches or pull requests
All predictor classes should be named
SoAndSoModelParameters
(likeKMeansModelParameters
,LinearBinaryModelParameters
etc.Strive to remove unnecessary interfaces from the public API: thinks like
IPredictor
,IPredictorProducing<float>
etc. should not be public.Review the public surface of
ModelParameters
to enable ONLY parameter introspection. For example:KMeans
should only expose centroid coordinates.Linear
should only expose weights/biases.KMeansModelParameters
from centroid coordinatesLinearBinaryModelParameters
from weights and biasesThe text was updated successfully, but these errors were encountered: