Skip to content

Final public API for predictor classes #1698

Closed
@Zruty0

Description

@Zruty0
  1. All predictor classes should be named SoAndSoModelParameters (like KMeansModelParameters, LinearBinaryModelParameters etc.

  2. Strive to remove unnecessary interfaces from the public API: thinks like IPredictor, IPredictorProducing<float> etc. should not be public.

  3. Review the public surface of ModelParameters to enable ONLY parameter introspection. For example:

  • KMeans should only expose centroid coordinates.
  • Linear should only expose weights/biases.
  1. If possible, try to add public constructors. For example:
  • Make it possible to create KMeansModelParameters from centroid coordinates
  • Make it possible to create LinearBinaryModelParameters from weights and biases

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions