Skip to content

Final public API for remaining learners #1703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Zruty0 opened this issue Nov 21, 2018 · 2 comments
Closed

Final public API for remaining learners #1703

Zruty0 opened this issue Nov 21, 2018 · 2 comments
Assignees

Comments

@Zruty0
Copy link
Contributor

Zruty0 commented Nov 21, 2018

Part of #1698

Let's make good public classes for trained artifacts of:

  • FFM

  • Naive Bayes

  • PCAAnomaly

  • MF

  • Any other trainers not covered in sub-issues of Final public API for predictor classes #1698

  • Move to an appropriate namespace inside Microsoft.ML

  • Reduce the public surface

  • Add public constructor

  • Add a sample

@singlis
Copy link
Member

singlis commented Dec 4, 2018

NOTE: public constructor should include consistent parameter usage and order (i.e. we have a pattern of LabelColumn, then FeaturesColumn). See #1806.

@najeeb-kazmi
Copy link
Member

NOTE: public constructor should include consistent parameter usage and order (i.e. we have a pattern of LabelColumn, then FeaturesColumn). See #1806.

@singlis The LabelColumn, FeaturesColumn pattern is in trainers. These work items are related to predictors instead, which I am renaming from Predictor to ModelParameters. So far, I have not seen instances of predictor constructors taking in label column or feature column, but if I do encounter one, I will stick to the convention that you describe.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants