Skip to content

Arguments class should be made internal when possible #1758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
artidoro opened this issue Nov 28, 2018 · 0 comments
Closed

Arguments class should be made internal when possible #1758

artidoro opened this issue Nov 28, 2018 · 0 comments
Assignees
@abgoswam @artidoro
Labels
API Issues pertaining the friendly API

Comments

@artidoro
Copy link
Contributor

For transformers like SlotsDroppingTransformer, and most other OneToOneTransformers, we implement a ColumnInfo object that allows to set all the transformation specific parameters. We should therefore make the Arguments class internal, as it is only used for the command line.
@artidoro artidoro added the API Issues pertaining the friendly API label Nov 28, 2018
@abgoswam abgoswam self-assigned this Dec 24, 2018
@sfilipi sfilipi self-assigned this Jan 18, 2019
This was referenced Jan 31, 2019
Closed
Merged
Merged
Merged
Merged
Merged
This was referenced Feb 3, 2019
Merged
Merged
@artidoro artidoro mentioned this issue Feb 12, 2019
Merged
@abgoswam abgoswam mentioned this issue Feb 14, 2019
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Mar 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@abgoswam abgoswam

@artidoro artidoro

Labels
API Issues pertaining the friendly API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@abgoswam @artidoro @sfilipi