-
Notifications
You must be signed in to change notification settings - Fork 1.9k
DataKind Enum is not well documented #2006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We do not want I believe I've mentioned in this one of my prior issues, but possibly not. At any rate I'm having trouble finding it again. 😛 |
@TomFinley - What should be used in place of DataKind for TextLoader field definition? Is there a best practice that you would recommend as you've said that use case is questionable? Thanks! |
@JRAlexander. In an ideal world. However what I'd prefer if we had a mechanism that didn't rely on
However, I don't insist on that. This may just be personal preference, but while I think But, that may be just me. Other people seem to tolerate the |
Since I opened this, to make this issue actionable, and not just a discussion placeholder: 1- I'll rename this issue to: Substitute internal usage of DataKind by the actual .net respective System.Type. IMO that can be done post Project 13 but please review its pri. 2- There is already an issue to cleanup the error messages from mentioning 3- Open an issue about investigating the TextLoader to potentially using the respective System.Type to load. Address backwards compatibility. cc @TomFinley @shauheen @glebuk @CESARDELATORRE to arrange priorities. |
See, that I might like even less than an enum, because it's less restrictive in a bad way. The set of types that the text loader can load is certainly finite. So, it should be somehow enumerated in a finite set, either in a finite set of an enum, or a finite set of calls with specific names (with the suggestion they are associated with specific types -- that type not being one provided by the user). Just clarifying, that while I don't like an enum, there are some things I might like even less than that. :) |
I'll try to explain what I mean perhaps better by analogy. If I consider the .NET BinaryReader class, I'd consider things in this order of desirability.
|
As changes are happening to data types this is not going to be an issue. Please reopen if you have other concerns. |
This issue was initially logged in the dotnet/docs repo 9278 and 9184.
@TomFinley, @CESARDELATORRE, @eerhardt Is the DataKind Enum something that will remain user facing, or will it get behind the .net types?
Should we document the DataKind or cleanup our error messages, and usage to not contain references to the DataKind anymore like #1943 suggest?
cc @mairaw @JRAlexander
The text was updated successfully, but these errors were encountered: