Skip to content

FastTree learning rate in advanced settings does not override the default value #2019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yaeldekel opened this issue Jan 4, 2019 · 0 comments · Fixed by #2047
Closed

FastTree learning rate in advanced settings does not override the default value #2019

yaeldekel opened this issue Jan 4, 2019 · 0 comments · Fixed by #2047

Comments

@yaeldekel
Copy link

These lines in the BoostingFastTreeTrainerBase ctor reset it to the value specified directly (or the default value):

        if (Args.LearningRates != learningRate)
        {
            using (var ch = Host.Start($"Setting learning rate to: {learningRate} as supplied in the direct arguments."))
                Args.LearningRates = learningRate;
        }

(Reported in #1983 .)

@ghost ghost locked as resolved and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant