-
Notifications
You must be signed in to change notification settings - Fork 1.9k
ValueMappingEstimator KeyType metadata maps to Key data and not to the Value data #2086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
bug
Something isn't working
Comments
singlis
added a commit
to singlis/machinelearning
that referenced
this issue
Jan 9, 2019
ValueMappingEstimator used a key type resulted in the reverse key lookup to fail. This was due to first the ValueMappingEstimator had an incorrect metadata set for GetOutputSchema. Also the reverse lookup data was set incorrectly and it would instead return the ValueMapping's Key data instead of the Value data. This also adds a test to verify the changes. Fixes dotnet#2086 Fixes dotnet#2083
singlis
added a commit
to singlis/machinelearning
that referenced
this issue
Jan 9, 2019
Values as KeyTypes: 1) The output schema for the Estimator did not contain the KeyType information in the metadata. 2) The reverse lookup of the metadata had the incorrect value. This now sets the correct metadata on the output schema and uses the value data for the reverse lookup. A test was added to confirm the changes using the KeyToValueMapping appended to a ValueMappingEstimator for the reverse lookup. Fixes dotnet#2086 Fixes dotnet#2083
singlis
added a commit
to singlis/machinelearning
that referenced
this issue
Jan 9, 2019
Values as KeyTypes: 1) The output schema for the Estimator did not contain the KeyType information in the metadata. 2) The reverse lookup of the metadata had the incorrect value. This now sets the correct metadata on the output schema and uses the value data for the reverse lookup. A test was added to confirm the changes using the KeyToValueMapping appended to a ValueMappingEstimator for the reverse lookup. Fixes dotnet#2086 Fixes dotnet#2083
singlis
added a commit
that referenced
this issue
Jan 15, 2019
* The ValueMappingEstimator had a couple of issues when using setting the Values as KeyTypes: 1) The output schema for the Estimator did not contain the KeyType information in the metadata. 2) The reverse lookup of the metadata had the incorrect value. This now sets the correct metadata on the output schema and uses the value data for the reverse lookup. A test was added to confirm the changes using the KeyToValueMapping appended to a ValueMappingEstimator for the reverse lookup. Fixes #2086 Fixes #2083
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Issue
Discovered while fixing #2083.
When creating a ValueMappingEstimator with KeyTypes as the values, the generated KeyType does not covert back to the original value. This is demonstrated when appending a KeyToValueTransform to retrieve the original values using the following code:
The expected results should be:
The actual results are:
The text was updated successfully, but these errors were encountered: