C# samples should probably use C# and not Python naming conventions

[TomFinley]

I was reading a PR when suddenly I saw something a bit odd.

machinelearning/docs/samples/Microsoft.ML.Samples/Dynamic/KeyToValue_Term.cs

Lines 42 to 47 in 6b9f589

	var customized_pipeline = new WordTokenizingEstimator(ml, "Review")
	.Append(new ValueToKeyMappingEstimator(ml, "Review", customizedColumnName, maxNumTerms: 10, sort: ValueToKeyMappingTransformer.SortOrder.Value));
	// The transformed data.
	var transformedData_default = default_pipeline.Fit(trainData).Transform(trainData);
	var transformedData_customized = customized_pipeline.Fit(trainData).Transform(trainData);

Note the underscores in the middle of a variable name. While in private we might elect to bend the rules a little bit, in our public API and also probably our samples, we probably ought to write them with consideration of standard practices. This does not seem to be a justifiable or explainable diversion from the recommended practice, and I'm guessing it was added by mistake.

Each individual renaming is probably not huge, but might span several files, since the example listed above is just one of many examples I see in our samples project. So not a "hard" change, except possibly in scale?

[ghost]

This would be a good first issue for me, can I take this?

[artidoro]

Sure! We would welcome your contribution and that looks like a good first issue.

[ghost]

Thanks, you can assign this to me, and ill begin working on it

[sfilipi]

This is completed with PR #2303

[sfilipi]

reopening, just noticed that those PRs, didn't get merge..

[shmoradims]

Samples were cleaned up as part of 1.0 API reference documentation. Please re-open with any wring naming instance you find.