Closed
Description
The Options
class for AveragedPerceptron and OnlineGradientDescent have a field LossFunction
which is used as a factory
Instead of using the factory pattern, they should be defined as IClassificationLoss
and IRegressionLoss
respectively.
That's what the public API also uses:
machinelearning/src/Microsoft.ML.StandardLearners/StandardLearnersCatalog.cs
Lines 167 to 172 in cabf55b
Refer to test case OnlineLinearWorkout