We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Options class for AveragedPerceptron and OnlineGradientDescent have a field LossFunction which is used as a factory
Options
LossFunction
machinelearning/src/Microsoft.ML.StandardLearners/Standard/Online/AveragedPerceptron.cs
Lines 42 to 46 in cabf55b
machinelearning/src/Microsoft.ML.StandardLearners/Standard/Online/OnlineGradientDescent.cs
Lines 38 to 43 in cabf55b
Instead of using the factory pattern, they should be defined as IClassificationLoss and IRegressionLoss respectively.
IClassificationLoss
IRegressionLoss
That's what the public API also uses:
machinelearning/src/Microsoft.ML.StandardLearners/StandardLearnersCatalog.cs
Lines 167 to 172 in cabf55b
Refer to test case OnlineLinearWorkout
OnlineLinearWorkout
@sfilipi
The text was updated successfully, but these errors were encountered:
ISupportBoosterParameterFactory
ganik
Successfully merging a pull request may close this issue.
The
Options
class for AveragedPerceptron and OnlineGradientDescent have a fieldLossFunction
which is used as a factorymachinelearning/src/Microsoft.ML.StandardLearners/Standard/Online/AveragedPerceptron.cs
Lines 42 to 46 in cabf55b
machinelearning/src/Microsoft.ML.StandardLearners/Standard/Online/OnlineGradientDescent.cs
Lines 38 to 43 in cabf55b
Instead of using the factory pattern, they should be defined as
IClassificationLoss
andIRegressionLoss
respectively.That's what the public API also uses:
machinelearning/src/Microsoft.ML.StandardLearners/StandardLearnersCatalog.cs
Lines 167 to 172 in cabf55b
Refer to test case
OnlineLinearWorkout
@sfilipi
The text was updated successfully, but these errors were encountered: