Skip to content

Need more details #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mairaw opened this issue May 24, 2018 · 6 comments
Closed

Need more details #223

mairaw opened this issue May 24, 2018 · 6 comments
Labels
documentation Related to documentation of ML.NET good first issue Good for newcomers up-for-grabs A good issue to fix if you are trying to contribute to the project
Milestone

Comments

@mairaw
Copy link
Contributor

mairaw commented May 24, 2018

@abidur commented on Wed May 23 2018

It would be nice to have more details on this beyond, "Number of weak hypotheses in the ensemble"


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@shauheen shauheen added the documentation Related to documentation of ML.NET label May 24, 2018
@shauheen
Copy link
Contributor

Thanks for filling, I think this is somewhat related to #160. We will publish more documentation as we go.

@justinormont
Copy link
Contributor

This string originates from:

[Argument(ArgumentType.LastOccurenceWins, HelpText = "Number of weak hypotheses in the ensemble", ShortName = "iter", SortOrder = 1)]

We should modify it to say something more user friendly. Perhaps, "Total number of boosted trees to create in the ensemble".

@codemzs: Is this parameter (and string value) inherited by other learners, like FastForest? The current wording seems oddly non-specific to boosted trees.

@justinormont justinormont added good first issue Good for newcomers up-for-grabs A good issue to fix if you are trying to contribute to the project labels May 24, 2018
@mitevpi
Copy link

mitevpi commented Jun 7, 2018

I couldn't find any references to the parameter in other learners. Also judging by the documentation of the arguments around it, it seems like this may have just missed a legibility update.

@shauheen
Copy link
Contributor

Thanks @jwood803 for #372 . @mairaw do you think we can close this issue now?

@mairaw
Copy link
Contributor Author

mairaw commented Jun 20, 2018

@abidur was the one who originally opened this issue in our repo.

@shauheen
Copy link
Contributor

shauheen commented Jul 5, 2018

Closing the issue, please file a new issue if the enhancements are not enough.

@shauheen shauheen closed this as completed Jul 5, 2018
@ghost ghost locked as resolved and limited conversation to collaborators Mar 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Related to documentation of ML.NET good first issue Good for newcomers up-for-grabs A good issue to fix if you are trying to contribute to the project
Projects
None yet
Development

No branches or pull requests

4 participants