Skip to content

Cleaning up metric classes #2624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Ivanidzo4ka opened this issue Feb 19, 2019 · 1 comment · Fixed by #2700
Closed

Cleaning up metric classes #2624

Ivanidzo4ka opened this issue Feb 19, 2019 · 1 comment · Fixed by #2700
Assignees
@codemzs
Labels
API Issues pertaining the friendly API
Milestone
0219

Comments

@Ivanidzo4ka
Copy link
Contributor

We need to clean our metrics classes:

All classes are sealed.
All constructors are internal.
Everything has proper documentation. Including class itself.
No short names (Dbi is awful name, DCG not great as well, L1, L2, Rms, etc)

List of metrics:
AnomalyDetectionMetrics
BinaryClassificationMetrics
CalibratedBinaryClassificationMetrics
ClusteringMetrics
MultiClassClassifierMetrics
RankerMetrics
RegressionMetrics
@Ivanidzo4ka Ivanidzo4ka added the API Issues pertaining the friendly API label Feb 19, 2019
@rogancarr
Copy link
Contributor

@Ivanidzo4ka I just filed a few related issues for ranking:

#2637
#2634
#2633

@codemzs codemzs self-assigned this Feb 22, 2019
@codemzs codemzs mentioned this issue Feb 22, 2019
Merged
@shauheen shauheen added this to the 0219 milestone Feb 23, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@codemzs codemzs

Labels
API Issues pertaining the friendly API
Projects
None yet
Milestone
0219
Development

Successfully merging a pull request may close this issue.

Clean up metrics classes. codemzs/machinelearning
4 participants
@codemzs @Ivanidzo4ka @shauheen @rogancarr