Skip to content

Ranking evaluator doesn't have defaults for Label and GroupId #2633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rogancarr opened this issue Feb 19, 2019 · 0 comments
Closed

Ranking evaluator doesn't have defaults for Label and GroupId #2633

rogancarr opened this issue Feb 19, 2019 · 0 comments
Assignees
@rogancarr
Labels
API Issues pertaining the friendly API

Comments

@rogancarr
Copy link
Contributor

The Evaluate() method for Ranking takes a label and groupId as input, but unlike other Evaluators and the ranking trainers, it does not have default values, so these must always be specified. This leads to an inconsistent feeling across the API surface.
@rogancarr rogancarr added the API Issues pertaining the friendly API label Feb 19, 2019
@rogancarr rogancarr self-assigned this Feb 19, 2019
This was referenced Feb 19, 2019
Closed
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rogancarr rogancarr

Labels
API Issues pertaining the friendly API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rogancarr