Skip to content

What to do with IFourierDistributionSampler and friends #2659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TomFinley opened this issue Feb 20, 2019 · 2 comments · Fixed by #2698
Closed

What to do with IFourierDistributionSampler and friends #2659

TomFinley opened this issue Feb 20, 2019 · 2 comments · Fixed by #2698
Assignees
Labels
API Issues pertaining the friendly API
Milestone

Comments

@TomFinley
Copy link
Contributor

This interface is related to random Fourier features projection. We may want this functionality as part of our public surface, but the specific API right now is still very command-line and entry-points centric. This should change.

Somewhat similar in spirit to the problem of loss functions as discussed in #1973, and has many of the same problems, and should probably have a similar resolution to whatever we choose to do with loss functions.

@TomFinley TomFinley added the API Issues pertaining the friendly API label Feb 20, 2019
@TomFinley
Copy link
Contributor Author

One area where it may differ from loss function si that due to their multi-inheritance and multi-appllication nature it kind of makes sense for loss functions to be interfaces, whereas I don't think these samplers should be interfaces; at least, nothing about this strikes me as being "interface-y."

@eerhardt
Copy link
Member

See also #699.

@yaeldekel yaeldekel self-assigned this Feb 20, 2019
@shauheen shauheen added this to the 0219 milestone Feb 25, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
API Issues pertaining the friendly API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants