Skip to content

Make trainer input arguments' names consistent #2680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shmoradims opened this issue Feb 21, 2019 · 3 comments · Fixed by #3029
Closed

Make trainer input arguments' names consistent #2680

shmoradims opened this issue Feb 21, 2019 · 3 comments · Fixed by #3029
Assignees
Labels
API Issues pertaining the friendly API

Comments

@shmoradims
Copy link

shmoradims commented Feb 21, 2019

Just by looking at StandardLearnersCatalog.cs I found a lot of inconsistent naming for the binary classification trainer arguments.

Below are the many naming variations that need to be conflated (both in extension method signatures and the Options properties):

  • labelColumnName, labelColumn
  • featureColumnName, featureColumn
  • weightColumnName, weights
  • initLearningRate, learningRate
  • l2Weight, l2Const, l2RegularizerWeight
  • l1Threshold, l1Weight
  • numIterations, maxIterations
  • lossFunction, loss
  • numIterations, NumberOfIterations

I haven't checked yet, but it's probably the case for other trainers. There's probably more of these inconsistencies.

@Ivanidzo4ka
Copy link
Contributor

#2613 feel free to contribute to that issue.

@Ivanidzo4ka Ivanidzo4ka added the API Issues pertaining the friendly API label Feb 21, 2019
@shauheen shauheen modified the milestone: 0219 Feb 22, 2019
@singlis
Copy link
Member

singlis commented Mar 1, 2019

@shmoradims, @Ivanidzo4ka can this be closed since its tracked under #2613?

@wschin
Copy link
Member

wschin commented Mar 6, 2019

Related to #2873 about weight column's name in trainers. I personally feel the current exampleWeightColumnName is too long and weightColumnName is clear enough. In addition, the definition of example is ambiguous in ML.NET as it can also be a code sample of a module.

@sfilipi sfilipi assigned sfilipi and unassigned sfilipi Mar 8, 2019
@wschin wschin self-assigned this Mar 18, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
API Issues pertaining the friendly API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants