Skip to content

exampleWeightColumnName v.s. weightColumnName #2873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wschin opened this issue Mar 6, 2019 · 3 comments
Closed

exampleWeightColumnName v.s. weightColumnName #2873

wschin opened this issue Mar 6, 2019 · 3 comments
Labels
API Issues pertaining the friendly API

Comments

@wschin
Copy link
Member

wschin commented Mar 6, 2019

In trainers like

        internal RandomizedPcaTrainer(IHostEnvironment env,
            string features,
            string weights = null,
            string featureColumnName,
            string exampleWeightColumnName = null,
            int rank = Options.Defaults.NumComponents,
            int oversampling = Options.Defaults.OversamplingParameters,
            bool center = Options.Defaults.IsCenteredZeroMean,
            bool ensureZeroMean = Options.Defaults.EnsureZeroMean,
            int? seed = null)

we have exampleWeightColumnName but it seems weightColumnName is clear enough under this context. Can we switch to weightColumnName?

@Ivanidzo4ka
Copy link
Contributor

origin of current name: #2257

@Ivanidzo4ka
Copy link
Contributor

actually #2177 (comment)

@wschin
Copy link
Member Author

wschin commented Mar 20, 2019

Now, I feel exampleWeightColumnName is actually a good name. There are too many places where Weight is included in a variable names. Having example can clarify those cases.

@wschin wschin closed this as completed Mar 20, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
API Issues pertaining the friendly API
Projects
None yet
Development

No branches or pull requests

3 participants