-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Namespace reorg for the public surface #2751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
There is more to do on this: |
Well issue states Microsoft.ML package, and none of this namespaces is in that package. |
Proposal for the final namespace landscape of the public surface:
The proposal above is me synthesizing the discussion we have had in the past about trainers. My personal opinion is that we should not have Microsoft.ML.Trainers.FastTree and Microsoft.ML.Trainers.LightGBM. We can fold them both into a Microsoft.ML.Trainers.Trees, call the linear ones Microsoft.ML.Trainers.Linear (ensembles can come on Microsoft.ML.Trainers.Ensembles, when time. ).
move to Microsoft.ML.Transforms.Onnx. The other namespaces that are not changing are:
@Ivanidzo4ka @TomFinley @eerhardt @wschin @shauheen @CESARDELATORRE |
I am not sure if |
I agree -- also I feel that external libraries like LightGBM ( and TensorFlow ) already create a natural separation from their name alone. |
Related to #2326, and the feedback of the ML.Net public surface API recommended the following changes:
1 - Microsoft.ML.Trainers.* everything should go to Microsoft.ML.Trainers, except FastTree.
2- Microsoft.ML.Transforms.* should go to Microsoft.ML.Transforms with the exception of Text and Images
cc @Ivanidzo4ka , @eerhardt @TomFinley
The text was updated successfully, but these errors were encountered: