Skip to content

Scrubbing of FeatureContributionCalculation and Explainability Catalog #2965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
artidoro opened this issue Mar 14, 2019 · 0 comments
Closed

Scrubbing of FeatureContributionCalculation and Explainability Catalog #2965

artidoro opened this issue Mar 14, 2019 · 0 comments
Assignees
@artidoro
Labels
API Issues pertaining the friendly API
Milestone
0319

Comments

@artidoro
Copy link
Contributor

artidoro commented Mar 14, 2019 •
edited
Loading

Explainability catalog should be cleaned up.

The MlContext.Model.Explainability catalog was created with the idea that all the model explainability operations would live there.

But it only contains FeatureContributionCalculation because PermutationFeatureImportance lives in the training task specific catalog (i.e. MlContext.BinaryClassification...) because it is task specific.

@rogancarr and @TomFinley agreed that it is not desirable to have a subcatalog with only one transform. And since FeatureContributionCalculation is an estimator/transformer it should probably live under:

MlContext.Transforms.FeatureContributionCalculation
@artidoro artidoro self-assigned this Mar 14, 2019
@artidoro artidoro added the API Issues pertaining the friendly API label Mar 14, 2019
@artidoro artidoro mentioned this issue Mar 14, 2019
Merged
@artidoro artidoro changed the title FeatureContributionCalculation and Explainability Catalog Scrubbing of FeatureContributionCalculation and Explainability Catalog Mar 14, 2019
@shauheen shauheen added this to the 0319 milestone Mar 14, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@artidoro artidoro

Labels
API Issues pertaining the friendly API
Projects
None yet
Milestone
0319
Development

No branches or pull requests
2 participants
@shauheen @artidoro