-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Clean FeatureContributionCalculation and PermutationFeatureImportance #2966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.../Microsoft.ML.Samples/Dynamic/PermutationFeatureImportance/PfiBinaryClassificationExample.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.ML.Transforms/PermutationFeatureImportanceExtensions.cs
Outdated
Show resolved
Hide resolved
Looking good! Just a few questions / comments. #Resolved |
574925e
to
ccf8fdd
Compare
Codecov Report
@@ Coverage Diff @@
## master #2966 +/- ##
=========================================
Coverage ? 72.35%
=========================================
Files ? 803
Lines ? 143295
Branches ? 16155
=========================================
Hits ? 103682
Misses ? 35189
Partials ? 4424
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #2965.
In this PR:
I move and rename the extension
MlContext.Model.Explainability.FeatureContributionCalculation
toMlContext.Transforms.CalculateFeatureContribution
.I also remove the
MlContext.Model.Explainability
catalog.Clean up the
FeatureContributionCalculation
extensionClean up PFI extensions