Skip to content

FeatureColumn vs FeatureColumnName in Model Transformers. #2975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rogancarr opened this issue Mar 15, 2019 · 0 comments · Fixed by #2990
Closed

FeatureColumn vs FeatureColumnName in Model Transformers. #2975

rogancarr opened this issue Mar 15, 2019 · 0 comments · Fixed by #2990
Assignees
@abgoswam
Labels
API Issues pertaining the friendly API
Milestone
0319

Comments

@rogancarr
Copy link
Contributor

In the public API, we've been switching FeatureColumn to FeatureColumnName. However, trained models like SDCA have FeatureColumnName in the input, but produce a Transformer that has a FeatureColumn property. I think this is widespread.
@rogancarr rogancarr added the API Issues pertaining the friendly API label Mar 15, 2019
@abgoswam abgoswam self-assigned this Mar 18, 2019
@abgoswam abgoswam mentioned this issue Mar 18, 2019
Merged
@shauheen shauheen added this to the 0319 milestone Mar 18, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@abgoswam abgoswam

Labels
API Issues pertaining the friendly API
Projects
None yet
Milestone
0319
Development

Successfully merging a pull request may close this issue.

Fix FeatureColumnName in the public API abgoswam/machinelearning
3 participants
@shauheen @abgoswam @rogancarr