Fix FeatureColumnName in the public API #2990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2990 +/- ##
==========================================
- Coverage 72.3% 72.29% -0.02%
==========================================
Files 796 796
Lines 142349 142349
Branches 16051 16051
==========================================
- Hits 102923 102908 -15
- Misses 35041 35061 +20
+ Partials 4385 4380 -5
|
rogancarr
reviewed
Mar 18, 2019
| /// <param name="numPositiveContributions">The number of positive contributions to report, sorted from highest magnitude to lowest magnitude. | ||
| /// Note that if there are fewer features with positive contributions than <paramref name="numPositiveContributions"/>, the rest will be returned as zeros.</param> | ||
| /// <param name="numNegativeContributions">The number of negative contributions to report, sorted from highest magnitude to lowest magnitude. | ||
| /// Note that if there are fewer features with negative contributions than <paramref name="numNegativeContributions"/>, the rest will be returned as zeros.</param> | ||
| /// <param name="normalize">Whether the feature contributions should be normalized to the [-1, 1] interval.</param> | ||
| public static FeatureContributionCalculatingEstimator FeatureContributionCalculation(this ModelOperationsCatalog.ExplainabilityTransforms catalog, | ||
| ICalculateFeatureContribution modelParameters, | ||
| string featureColumn = DefaultColumnNames.Features, |
There was a problem hiding this comment.
featureColumn = [](start = 19, length = 16)
#2966 rewrites these functions, so you can drop changes to ExplainabilityCatalog.
There was a problem hiding this comment.
That would be much appreciated indeed :)
rogancarr
approved these changes
Mar 18, 2019
artidoro
approved these changes
Mar 19, 2019
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2975
featureColumnparameter in ExplanabilityCatalog.cs