Skip to content

Use new Microsoft.DotNet.RemoteExecutor package #3164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Anipik opened this issue Apr 2, 2019 · 7 comments
Open

Use new Microsoft.DotNet.RemoteExecutor package #3164

Anipik opened this issue Apr 2, 2019 · 7 comments
Labels
need info This issue needs more info before triage P3 Doc bugs, questions, minor issues, etc.

Comments

@Anipik
Copy link
Contributor

Anipik commented Apr 2, 2019

Dotnet team just added a new package in the arcade repo called Microsoft.DotNet.RemoteExecutor package. dotnet/arcade#2176

We use a lot of code from this project to run our tests. This code was added in #2200

Although slight modifications were made to the code to handle Microsoft.ML based scenarios.
But i think we should be able to use this package to run other tests.

cc @ViktorHofer

@eerhardt
Copy link
Member

eerhardt commented Apr 4, 2019

Note that dotnet/machinelearning doesn't use dotnet/arcade at all just yet. Will it be possible to use just the RemoteExecutor package without upgrading the rest of the build system to arcade?

@ViktorHofer
Copy link
Member

Sure, just consume the dotnet-core feed: https://github.com/dotnet/arcade#getting-started

@mstfbl mstfbl added the need info This issue needs more info before triage label Jan 9, 2020
@harishsk harishsk added the P3 Doc bugs, questions, minor issues, etc. label Jan 22, 2020
@mstfbl
Copy link
Contributor

mstfbl commented Apr 21, 2020

Closing this issue as no further updates on the issue have been given. @Anipik feel free to reopen the issue if you can provide more information. Thanks.

@mstfbl mstfbl closed this as completed Apr 21, 2020
@ViktorHofer
Copy link
Member

Curious why the "need-more-info" label was applied even though no question was asked? This issue shouldn't be closed as it still applies.

@harishsk
Copy link
Contributor

Can you please share what the Microsoft.DotNet.RemoteExecutor is and why we should be using it?
We have a plan to upgrade to to Arcade. But it is not high priority right now.

@ViktorHofer
Copy link
Member

Can you please share what the Microsoft.DotNet.RemoteExecutor is

Out of process execution of test code. Necessary when environment variables or other process states need to be mutated.

and why we should be using it

You are already using it:

public static class RemoteExecutor
. This is an outdated copy from CoreFx. Meanwhile we moved RemoteExecutor to Arcade.

The ask is that you get rid of the copy and just use the nuget feed from Arcade. There's no dependency on "arcadifying" the dependency to consume that package. It's just a nuget package which lives on a feed. Let me know if you need more details.

@ViktorHofer
Copy link
Member

@mstfbl can we please reopen the issue before it's lost in dev/null?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need info This issue needs more info before triage P3 Doc bugs, questions, minor issues, etc.
Projects
None yet
Development

No branches or pull requests

5 participants