Skip to content

Tests for Sse and Software implementations #2200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 25, 2019
Merged

Tests for Sse and Software implementations #2200

merged 6 commits into from
Jan 25, 2019

Conversation

Anipik
Copy link
Contributor

@Anipik Anipik commented Jan 22, 2019

Fixes #1156

This pr adds tests for sse and software implementation of cpumath functions

@eerhardt
Copy link
Member

using System;

copyright


Refers to: test/RemoteExecutorConsoleApp/RemoteExecutorConsoleApp.cs:1 in 8be2e3c. [](commit_id = 8be2e3c, deletion_comment = False)

@tannergooding
Copy link
Member

@Anipik, I think something is likely wrong with either the build you are using or how you are setting the environment variables.

Testing locally (on a release build of CoreCLR), I see the variables working as intended.

D:\repos\coreclr\bin\tests\Windows_NT.x64.Release\JIT\HardwareIntrinsics\X86\Sse\Sse_ro [master ≡]> D:\repos\coreclr\bin\tests\Windows_NT.x64.Release\Tests\Core_Root\CoreRun.exe .\Sse_ro.exe Add.Single
Supported ISAs:
  AES:       True
  AVX:       True
  AVX2:      True
  BMI1:      True
  BMI2:      True
  FMA:       True
  LZCNT:     True
  PCLMULQDQ: True
  POPCNT:    True
  SSE:       True
  SSE2:      True
  SSE3:      True
  SSE4.1:    True
  SSE4.2:    True
  SSSE3:     True

Beginning test case Add.Single at 1/22/2019 3:54:18 PM
Random seed: 20010415; set environment variable CORECLR_SEED to this value to repro

Beginning scenario: RunBasicScenario_UnsafeRead
Beginning scenario: RunBasicScenario_Load
Beginning scenario: RunBasicScenario_LoadAligned
Beginning scenario: RunReflectionScenario_UnsafeRead
Beginning scenario: RunReflectionScenario_Load
Beginning scenario: RunReflectionScenario_LoadAligned
Beginning scenario: RunClsVarScenario
Beginning scenario: RunLclVarScenario_UnsafeRead
Beginning scenario: RunLclVarScenario_Load
Beginning scenario: RunLclVarScenario_LoadAligned
Beginning scenario: RunClassLclFldScenario
Beginning scenario: RunClassFldScenario
Beginning scenario: RunStructLclFldScenario
Beginning scenario: RunStructFldScenario

Ending test case at 1/22/2019 3:54:18 PM
D:\repos\coreclr\bin\tests\Windows_NT.x64.Release\JIT\HardwareIntrinsics\X86\Sse\Sse_ro [master ≡]> $env:COMPlus_EnableHWIntrinsic=0
D:\repos\coreclr\bin\tests\Windows_NT.x64.Release\JIT\HardwareIntrinsics\X86\Sse\Sse_ro [master ≡]> D:\repos\coreclr\bin\tests\Windows_NT.x64.Release\Tests\Core_Root\CoreRun.exe .\Sse_ro.exe Add.Single
Supported ISAs:
  AES:       False
  AVX:       False
  AVX2:      False
  BMI1:      False
  BMI2:      False
  FMA:       False
  LZCNT:     False
  PCLMULQDQ: False
  POPCNT:    False
  SSE:       False
  SSE2:      False
  SSE3:      False
  SSE4.1:    False
  SSE4.2:    False
  SSSE3:     False

Beginning test case Add.Single at 1/22/2019 3:54:29 PM
Random seed: 20010415; set environment variable CORECLR_SEED to this value to repro

Beginning scenario: RunUnsupportedScenario
Beginning scenario: RunBasicScenario_UnsafeRead

Ending test case at 1/22/2019 3:54:29 PM
D:\repos\coreclr\bin\tests\Windows_NT.x64.Release\JIT\HardwareIntrinsics\X86\Sse\Sse_ro [master ≡]> $env:COMPlus_EnableHWIntrinsic=1; $env:COMPlus_EnableSse=0
D:\repos\coreclr\bin\tests\Windows_NT.x64.Release\JIT\HardwareIntrinsics\X86\Sse\Sse_ro [master ≡]> D:\repos\coreclr\bin\tests\Windows_NT.x64.Release\Tests\Core_Root\CoreRun.exe .\Sse_ro.exe Add.Single
Supported ISAs:
  AES:       False
  AVX:       False
  AVX2:      False
  BMI1:      False
  BMI2:      False
  FMA:       False
  LZCNT:     True
  PCLMULQDQ: False
  POPCNT:    False
  SSE:       False
  SSE2:      False
  SSE3:      False
  SSE4.1:    False
  SSE4.2:    False
  SSSE3:     False

Beginning test case Add.Single at 1/22/2019 3:55:03 PM
Random seed: 20010415; set environment variable CORECLR_SEED to this value to repro

Beginning scenario: RunUnsupportedScenario
Beginning scenario: RunBasicScenario_UnsafeRead

Ending test case at 1/22/2019 3:55:03 PM
D:\repos\coreclr\bin\tests\Windows_NT.x64.Release\JIT\HardwareIntrinsics\X86\Sse\Sse_ro [master ≡]> $env:COMPlus_EnableSse=1; $env:COMPlus_EnableAvx=0
D:\repos\coreclr\bin\tests\Windows_NT.x64.Release\JIT\HardwareIntrinsics\X86\Sse\Sse_ro [master ≡]> D:\repos\coreclr\bin\tests\Windows_NT.x64.Release\Tests\Core_Root\CoreRun.exe .\Sse_ro.exe Add.Single
Supported ISAs:
  AES:       True
  AVX:       False
  AVX2:      False
  BMI1:      False
  BMI2:      False
  FMA:       False
  LZCNT:     True
  PCLMULQDQ: True
  POPCNT:    True
  SSE:       True
  SSE2:      True
  SSE3:      True
  SSE4.1:    True
  SSE4.2:    True
  SSSE3:     True

Beginning test case Add.Single at 1/22/2019 3:55:20 PM
Random seed: 20010415; set environment variable CORECLR_SEED to this value to repro

Beginning scenario: RunBasicScenario_UnsafeRead
Beginning scenario: RunBasicScenario_Load
Beginning scenario: RunBasicScenario_LoadAligned
Beginning scenario: RunReflectionScenario_UnsafeRead
Beginning scenario: RunReflectionScenario_Load
Beginning scenario: RunReflectionScenario_LoadAligned
Beginning scenario: RunClsVarScenario
Beginning scenario: RunLclVarScenario_UnsafeRead
Beginning scenario: RunLclVarScenario_Load
Beginning scenario: RunLclVarScenario_LoadAligned
Beginning scenario: RunClassLclFldScenario
Beginning scenario: RunClassFldScenario
Beginning scenario: RunStructLclFldScenario
Beginning scenario: RunStructFldScenario

Ending test case at 1/22/2019 3:55:20 PM
D:\repos\coreclr\bin\tests\Windows_NT.x64.Release\JIT\HardwareIntrinsics\X86\Sse\Sse_ro [master ≡]>

@Anipik
Copy link
Contributor Author

Anipik commented Jan 23, 2019

@eerhardt can you take another look at this ?

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Anipik !

@codecov
Copy link

codecov bot commented Jan 25, 2019

Codecov Report

Merging #2200 into master will increase coverage by 10.97%.
The diff coverage is 74.78%.

@@             Coverage Diff             @@
##           master    #2200       +/-   ##
===========================================
+ Coverage   69.82%   80.79%   +10.97%     
===========================================
  Files         784      159      -625     
  Lines      143534    28499   -115035     
  Branches    16596     1915    -14681     
===========================================
- Hits       100228    23027    -77201     
+ Misses      38770     5175    -33595     
+ Partials     4536      297     -4239
Flag Coverage Δ
#Debug 80.79% <74.78%> (+10.97%) ⬆️
#production ?
#test 80.79% <74.78%> (-4.17%) ⬇️

@Anipik Anipik merged commit 8cdfa61 into dotnet:master Jan 25, 2019
@Anipik Anipik deleted the intrinsics branch January 25, 2019 23:55
@ghost ghost locked as resolved and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants