-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Tests for Sse and Software implementations #2200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
test/RemoteExecutorConsoleApp/RemoteExecutorConsoleApp.runtimeconfig.json
Outdated
Show resolved
Hide resolved
@Anipik, I think something is likely wrong with either the build you are using or how you are setting the environment variables. Testing locally (on a release build of CoreCLR), I see the variables working as intended.
|
@eerhardt can you take another look at this ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @Anipik !
…oftware implemenatation path, setting environmentvariables, removed remote executorHandle and Dispose
Codecov Report
@@ Coverage Diff @@
## master #2200 +/- ##
===========================================
+ Coverage 69.82% 80.79% +10.97%
===========================================
Files 784 159 -625
Lines 143534 28499 -115035
Branches 16596 1915 -14681
===========================================
- Hits 100228 23027 -77201
+ Misses 38770 5175 -33595
+ Partials 4536 297 -4239
|
Fixes #1156
This pr adds tests for sse and software implementation of cpumath functions