Skip to content

Iris data set (iris.txt) is not correct #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pkulikov opened this issue Jun 24, 2018 · 3 comments
Closed

Iris data set (iris.txt) is not correct #400

pkulikov opened this issue Jun 24, 2018 · 3 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers test related to tests up-for-grabs A good issue to fix if you are trying to contribute to the project

Comments

@pkulikov
Copy link
Contributor

pkulikov commented Jun 24, 2018

/test/data folder contains two files related to the iris data set:

Problem: iris.txt does not match iris.data.

Let's forget about the Label column and consider only the feature columns. While those columns in iris.txt are named in the same order as they are in the iris.data, the data values were somehow mixed.

First lines of the iris.data:

5.1,3.5,1.4,0.2,Iris-setosa
4.9,3.0,1.4,0.2,Iris-setosa
4.7,3.2,1.3,0.2,Iris-setosa

First lines of the iris.txt:

#Label	Sepal length	Sepal width	Petal length	Petal width
0	3.5	1.4	0.2	5.1
0	3.0	1.4	0.2	4.9
0	3.2	1.3	0.2	4.7

The last column in the iris.txt must be second shifting other feature columns by one to the right. Petals of length 0.2 cm and width 5.1 cm are not natural :).

//cc @OliaG as the iris data sets in the dotnet/machinelearning-samples look to be produced from the iris.txt file.

@shauheen shauheen added bug Something isn't working test related to tests labels Jun 25, 2018
@shauheen
Copy link
Contributor

@pkulikov thanks for reporting this issue.

@shauheen shauheen added good first issue Good for newcomers up-for-grabs A good issue to fix if you are trying to contribute to the project labels Jun 25, 2018
@OliaG OliaG self-assigned this Jun 25, 2018
@Nepomuceno
Copy link
Contributor

Should this issue be closed now ?

@artidoro
Copy link
Contributor

Closing in favor of #428 and #527

@ghost ghost locked as resolved and limited conversation to collaborators Mar 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working good first issue Good for newcomers test related to tests up-for-grabs A good issue to fix if you are trying to contribute to the project
Projects
None yet
Development

No branches or pull requests

5 participants