-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fix iris.txt dataset and modify Iris Classification tests accordingly #428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ok, just realized some additional tests need to be covered. #Resolved |
Thanks for taking care of this, Bojan. Take a look at the results of the tests as well, they might need update since the dataset is changing quite a bit. In reply to: 400616611 [](ancestors = 400616611) |
Thanks Senja! Removing
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…dotnet#428) * Fix iris.txt dataset and modify Iris Classification tests accordingly * Modify baseline test files for multiclass classification with Iris dataset and LightGBM
Related to issue #400.
Reordered column values in
iris.txt
(headers stay the same), so the previouslyPetal width
values are actuallySepal length
values; other columns shifted to the right.Tests
TrainAndPredictIrisModelTest
andTrainAndPredictIrisModelWithStringLabelTest
are modified accordingly so that the values that test the prediction are also reordered to be more realistic (same way the dataset is modified).Model class
IrisDataWithStringLabel
fields reordered to matchiris.data
dataset.The fix for the samples repo that uses the same dataset will follow.