-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Replace SubComponent with IComponentFactory #585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Milestone
Comments
eerhardt
added a commit
to eerhardt/machinelearning
that referenced
this issue
Aug 15, 2018
eerhardt
added a commit
to eerhardt/machinelearning
that referenced
this issue
Aug 17, 2018
eerhardt
added a commit
to eerhardt/machinelearning
that referenced
this issue
Aug 17, 2018
eerhardt
added a commit
that referenced
this issue
Aug 17, 2018
* Convert Ensemble stacking SubComponent to IComponentFactory. * Replace SubComponent with IComponentFactory in ML.Ensemble Working towards #585 * Convert SimpleComponentFactory classes to ComponentFactoryUtils static class. * Move Stacking arguments abstract properties to internal get methods. This reduces the public surface area.
eerhardt
added a commit
to eerhardt/machinelearning
that referenced
this issue
Aug 20, 2018
eerhardt
added a commit
to eerhardt/machinelearning
that referenced
this issue
Aug 20, 2018
This was referenced Aug 24, 2018
eerhardt
added a commit
to eerhardt/machinelearning
that referenced
this issue
Sep 4, 2018
Working towards dotnet#585
eerhardt
added a commit
to eerhardt/machinelearning
that referenced
this issue
Sep 7, 2018
Working towards dotnet#585
eerhardt
added a commit
that referenced
this issue
Sep 8, 2018
Follow up for some PR feedback from the PipelineInference removal of SubComponent. Working towards #585
This work is now complete. SubComponent no longer exists in ML.NET. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When a component is structured in a way that it can use some other component, we are currently using a
SubComponent
object to specify which other component to use. For example, our One-Versus-All (Ova) class can turn any binary classifier into a multi-class classifier. So it has aSubComponent PredictorType
field on itsArguments
class, and users can specify which binary classifier that Ova should use.The issues with SubComponent are:
In our main API, we shouldn't be using magic strings, or dependency injection, when you can simply just create objects, or delegates/factories, like a normal OOP API would work.
The text was updated successfully, but these errors were encountered: