Skip to content

CpuMath Enhancement: Accelerate loops in hardware intrinsics implementation #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
briancylui opened this issue Sep 5, 2018 · 2 comments
Closed

CpuMath Enhancement: Accelerate loops in hardware intrinsics implementation #831

briancylui opened this issue Sep 5, 2018 · 2 comments
Labels
up-for-grabs A good issue to fix if you are trying to contribute to the project

Comments

@briancylui
Copy link
Contributor

Style changes needed to solve part of #823

Details

  • Make while loops more efficient in src\Microsoft.ML.CpuMath\SseIntrinsics.cs and src\Microsoft.ML.CpuMath\AvxIntrinsics.cs with modified bound checking:
var remainder = count % elementsPerIteration;
float* pEnd = pdst + (count - remainder);
while (pDstCurrent < pEnd)
{ … }
@briancylui briancylui changed the title Accelerate loops in hardware intrinsics implementation CpuMath Enhancement: Accelerate loops in hardware intrinsics implementation Sep 6, 2018
@danmoseley danmoseley added the up-for-grabs A good issue to fix if you are trying to contribute to the project label Oct 29, 2018
@danmoseley
Copy link
Member

@tannergooding is this still relevant? I am not sure where it applies, after #835

@tannergooding
Copy link
Member

No, they look like dupes of eachother.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
up-for-grabs A good issue to fix if you are trying to contribute to the project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@danmoseley @tannergooding @briancylui