Skip to content

Native dependencies of ML.NET #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ericstj opened this issue Sep 12, 2018 · 3 comments
Closed

Native dependencies of ML.NET #895

ericstj opened this issue Sep 12, 2018 · 3 comments

Comments

@ericstj
Copy link
Member

ericstj commented Sep 12, 2018

We should review and try to unify and document the native dependencies of ML.NET, in particular the VC-runtime.

Ideally we should try and build the native components in the same way that .NET Core does so that we don't impose any new requirements (eg: installing a different / specific version of the VC redist).

I checked a few DLLs using link /dump /imports and noticed a lot of instances of VCRUNTIME140 which we do not depend on for coreclr/clrcompression/clrjit/etc.

I just did this check for Windows but we should also look at a similar thing on linux.

We should also examine binary redists (like TensorFlow) so that we can understand if they are different and at least document their dependencies.

/cc @shauheen @tannergooding @danmosemsft @eerhardt

@eerhardt
Copy link
Member

Do you know how to eliminate the import of VCRUNTIME140? I took the native build code/infrastructure from a mix of core-setup and corefx, but may have missed something in the CMake files.

@ericstj
Copy link
Member Author

ericstj commented Sep 12, 2018

@eerhardt
Copy link
Member

eerhardt commented Feb 1, 2019

We’ve started static linking the VC Runtime in #1828. Closing.

@eerhardt eerhardt closed this as completed Feb 1, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants