Allow ML.NET native binaries to work on Windows machines that don't have the VC runtime installed. #1828
Conversation
…ave the VC runtime installed. This allows ML.NET to run on Windows Nano containers. I also ported 2 Unix compile options we are using in core-setup and corefx that were missed when originally creating the ML.NET native build infrastructure. Fix dotnet#1823
eerhardt
requested review from
Ivanidzo4ka,
artidoro,
singlis,
safern and
montebhoover
| @@ -62,6 +65,8 @@ if(WIN32) | |||
| list(APPEND RESOURCES ${CMAKE_SOURCE_DIR}/../../Tools/NativeVersion.rc) | |||
| else() | |||
| add_compile_options(-Wno-unused-local-typedef) | |||
| add_compile_options(-fPIC) | |||
There was a problem hiding this comment.
I originally missed these setting because I copied the "common" CMake file from dotnet/core-setup. However, /MT for Windows and these two settings on Unix aren't in the common CMake file in that repo, but are spread to the individual CMake files for each library:
https://github.com/dotnet/core-setup/blob/8fe49b4211abaa649784966a4f6b55a38a237d9e/src/corehost/cli/hostpolicy/CMakeLists.txt#L7-L14
https://github.com/dotnet/core-setup/blob/8fe49b4211abaa649784966a4f6b55a38a237d9e/src/corehost/cli/fxr/CMakeLists.txt#L7-L14
Which is why they were overlooked originally.
|
I tried with version 0.10 it still does not find the CPUMathNative, |
|
Shouldn't this be STATIC instead of SHARED ? |
|
@spsinghats - can you open a new issue with your repro steps? |
ghost
locked as resolved and limited conversation to collaborators
This allows ML.NET to run on Windows Nano containers.
I also ported 2 Unix compile options we are using in core-setup and corefx that were missed when originally creating the ML.NET native build infrastructure.
Fix #1823