Skip to content

Add/expose random seed in LearningPipeline to get deterministic results #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GalOshri opened this issue May 4, 2018 · 4 comments
Closed
Labels
enhancement New feature or request
Milestone

Comments

@GalOshri
Copy link
Contributor

GalOshri commented May 4, 2018

It is important to be able to set a random seed for ML experiments so the results are reproducible. Add random seed to LearningPipeline (or elsewhere) to ensure a full experiment is deterministic.

@markusweimer
Copy link
Member

Which of those variants do you prefer?

  // Variant 1: Constructor
  var p = new LearningPipeline(seed:1234);

  // Variant 2: Property
  p.seed = 1234;

  // Variant 3: Parameter to .Train()
  var m = p.Train(seed:1234);

@shauheen shauheen added enhancement New feature or request up-for-grabs A good issue to fix if you are trying to contribute to the project labels May 9, 2018
@shauheen shauheen added this to the 0518 milestone May 9, 2018
@shauheen shauheen removed the up-for-grabs A good issue to fix if you are trying to contribute to the project label May 9, 2018
@zeahmed
Copy link
Contributor

zeahmed commented May 11, 2018

I'll prefer

// Variant 3: Parameter to .Train()
var m = p.Train(seed:1234);

@TomFinley
Copy link
Contributor

TomFinley commented May 11, 2018

Seriously, enough is enough I think. Let's just expose IHostEnvironment. That's our mechanism to solve this and other problems, it's worked well for years doing exactly this among all its other functions.

@shauheen
Copy link
Contributor

With a few PRs already merged as well as the proposed #371 , this issue can now be closed.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants