Skip to content

TensorFlowTransform does not implement IDisposable. #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
abgoswam opened this issue Sep 13, 2018 · 1 comment
Closed

TensorFlowTransform does not implement IDisposable. #906

abgoswam opened this issue Sep 13, 2018 · 1 comment
Assignees
@abgoswam

Comments

@abgoswam
Copy link
Member

abgoswam commented Sep 13, 2018 •
edited
Loading

TensorFlowTransform does not implement IDisposable.

Instead the Finalizer directly calls the private Dispose() method to free resources. We need to understand the reasoning behind ML.NET Transforms not implementing IDisposable

Discussion
@abgoswam abgoswam mentioned this issue Sep 13, 2018
Merged
@abgoswam abgoswam self-assigned this Sep 21, 2018
@abgoswam abgoswam changed the title TensorFlowTransform does not dispose TFSession TensorFlowTransform does not implement IDisposable. Sep 21, 2018
@codemzs
Copy link
Member

codemzs commented Jun 30, 2019

I don't see this as an issues as the same applies for every other transform. Please add more details to why you believe this is an issue and we can reopen.

@codemzs codemzs closed this as completed Jun 30, 2019
@eerhardt eerhardt mentioned this issue Dec 5, 2019
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Mar 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@abgoswam abgoswam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@codemzs @abgoswam