Skip to content

PipeBase<TMessage> should implement the Dispose Pattern correctly #930

Closed
@eerhardt

Description

@eerhardt

The PipeBase class implements IDisposable, but doesn't implement the basic pattern correctly.

public void Dispose()
{
DisposeCore();
}
protected virtual void DisposeCore()
{
IsActive = false;
}

See https://docs.microsoft.com/en-us/dotnet/standard/design-guidelines/dispose-pattern for the basic dispose pattern.

We should follow the design guidelines here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    up-for-grabsA good issue to fix if you are trying to contribute to the project

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions