Skip to content

Update input arguments in CpuMath files #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Nov 7, 2018
Merged

Update input arguments in CpuMath files #1021

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
a28701b
Start renaming arguments
jwood803 Sep 17, 2018
00c5cdb
Merge branch 'master' into cpu-rename-arguments
jwood803 Sep 21, 2018
177edd9
Start updating parameter names
jwood803 Sep 22, 2018
70226ba
Update parameter names
jwood803 Sep 25, 2018
eb42375
Merge branch 'master' into cpu-rename-arguments
jwood803 Sep 25, 2018
5926e60
Update naming of method
jwood803 Sep 25, 2018
6ee9669
Update argument names due to PR feedback
jwood803 Sep 25, 2018
82542b7
Update more argument names
jwood803 Sep 25, 2018
287f7fc
Remove unused argument
jwood803 Sep 27, 2018
d6a677d
Update net standard file
jwood803 Oct 1, 2018
d228f73
Merge branch 'master' into cpu-rename-arguments
jwood803 Oct 1, 2018
aa93772
Regen entry points after merging
jwood803 Oct 1, 2018
0ab973b
Update more argument names and revert test skip
jwood803 Oct 1, 2018
60fb9cd
Merge branch 'master' into cpu-rename-arguments
jwood803 Oct 3, 2018
dc99725
Fix compile issues in .NET Core compile
jwood803 Oct 3, 2018
82dfdcf
Revert removal of argument
jwood803 Oct 3, 2018
a21dcf3
Update more parameter names
jwood803 Oct 5, 2018
089fe54
Merge from master
jwood803 Oct 5, 2018
0a6ce77
Remove unused parameter
jwood803 Oct 5, 2018
ca153eb
Fix build errors for removing length parameter
jwood803 Oct 6, 2018
9f4c267
Merge from master
jwood803 Oct 13, 2018
dcbaf69
Update test arguments
jwood803 Oct 13, 2018
2a1a8dd
Update more argument names
jwood803 Oct 13, 2018
d01b460
Merge branch 'master' into cpu-rename-arguments
jwood803 Oct 28, 2018
46b31a9
Fix merge issues
jwood803 Oct 29, 2018
2ae946a
Merge branch 'master' into cpu-rename-arguments
jwood803 Oct 29, 2018
3fe14e6
Further PR updates
jwood803 Oct 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Microsoft.ML.CpuMath/CpuAligenedMathUtils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ public static void MatTimesSrc(ICpuFullMatrix mat, ICpuVector src, ICpuVector ds
bool colMajor = typeof(TMatrix) == typeof(CpuAlignedMatrixCol);
AssertCompatible(mat, src, dst);
var m = A(mat);
CpuMathUtils.MatTimesSrc(colMajor, m.Items, A(src).Items, A(dst).Items, m.RunCnt);
CpuMathUtils.MatrixTimesSource(colMajor, m.Items, A(src).Items, A(dst).Items, m.RunCnt);
}

/// <summary>
Expand All @@ -100,7 +100,7 @@ public static void MatTranTimesSrc(ICpuFullMatrix mat, ICpuVector src, ICpuVecto
bool colMajor = typeof(TMatrix) == typeof(CpuAlignedMatrixCol);
AssertCompatible(mat, dst, src);
var m = A(mat);
CpuMathUtils.MatTimesSrc(!colMajor, m.Items, A(src).Items, A(dst).Items, m.RunCnt);
CpuMathUtils.MatrixTimesSource(!colMajor, m.Items, A(src).Items, A(dst).Items, m.RunCnt);
}
}

Expand Down
Loading