-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Issue #104: Update the build tools to 2.1.200 #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Issues: This closes dotnet#104
From a new person's perspective, this can be a bit confusing. "BuildTools" is a non-shipping set of tools used by the .NET Core repos. It is a set of extensions built on top of the .NET Core SDK that is a public shipping product. The available versions of build tools can be seen here: https://dotnet.myget.org/feed/dotnet-buildtools/package/nuget/Microsoft.DotNet.BuildTools The version of the .NET Core SDK we are using is located in https://github.com/dotnet/machinelearning/blob/master/DotnetCLIVersion.txt. (I know it is a bad name, but it is the same name that the rest of the .NET Core repos use...) I think we can update both of these to the "latest". .NET Core SDK => 2.1.200. BuildTools => 2.2.0-preview1-02808-01. @markusweimer - I can update this PR to make these updates, if you want. Let me know. |
Oooh, now I get it. Please go ahead and make the changes, @eerhardt. I will hunt for something else as my 1st commit :) |
You can totally do it, in order to get your "1st commit" badge 😃 . You just need to change which file you are updating. machinelearning/DotnetCLIVersion.txt Line 1 in e1db5c5
|
Just curious, does moving to .NET Core 2.1 give anything to us yet? I'm very excited about some things in it ( |
@eerhardt, I have updated the other file :) @TomFinley : We are already using .NET Core 2.1 SDK, but a preview instead of the release candidate. Note that IIRC, the SDK used is independent of the runtime target of the code. This PR doesn't change the target away from |
Ah makes sense, thanks. In reply to: 387902080 [](ancestors = 387902080) |
I couple comments about the above, since this isn't stuff is hard to keep up with. From the original issue:
The .NET Core Runtime and SDK have been versioning at different paces. When 2.0 was released, both the runtime and SDK were v2.0 at the same time. Their versions matched. However, after the 2.0 runtime was released, there were new features added to the SDK that were more than just a patch version could take (new C# version, new MSBuild features, NuGet features, etc.). At that time, it was decided to bump the SDK version to 2.1 in order to convey that there were more than just bug fixes in this release. However, the runtime didn't release a new version at the same time. So the 2.1 SDK still came with the 2.0 runtime. People saw the huge issue this was going to be. So we came up with a plan documented at https://github.com/dotnet/designs/pull/29/files. The summary of the plan is that the SDK
As stated above, with this change we still use the 2.0 runtime, and the latest released SDK.
|
* Issue dotnet#104: Update the build tools to 2.1.200 Issues: This closes dotnet#104 * Updating .NET Version in the right file.
Issues:
This closes #104