FastTree: Instantiate feature map for disk transpose and make Generalized Additive Models predictor resilient when feature map is not available. #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #123 #Resolved |
TomFinley
reviewed
May 11, 2018
|
|
||
| //No features were filtered. | ||
| if (_featureMap == null) | ||
| _featureMap = Enumerable.Range(0, trainSet.NumFeatures).ToArray(); |
There was a problem hiding this comment.
Utils.GetIdentityPermutation? #Resolved
|
Cool thanks Zeeshan. Would any test help cover this issue, or would this perhaps wait till we moved more of the baseline test over? #Resolved |
|
Thanks for reviewing Tom. I have added two tests, one for fasttree and other for GAM. In reply to: 388231158 [](ancestors = 388231158) |
TomFinley
suggested changes
May 11, 2018
shauheen
approved these changes
May 12, 2018
eerhardt
pushed a commit
to eerhardt/machinelearning
that referenced
this pull request
Jul 27, 2018
…ized Additive Models predictor resilient when feature map is not available. (dotnet#122) * Instantiate feature map for disk transpose and make Generalized Additive Models predictor resilient when feature map is not available.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.