Change IModelCombiner to not be generic, and add unit tests #1305
Conversation
| CombineAndTestEnsembles(dataView, "pe", "oc=average", PredictionKind.BinaryClassification, predictors); | ||
| } | ||
|
|
||
| [ConditionalFact(typeof(Environment), nameof(Environment.Is64BitProcess))] // x86 fails with "Unknown command: 'train'; Format error at (83,3)-(83,4011): Illegal quoting" |
There was a problem hiding this comment.
// x86 fails with "Unknown command: 'train'; Format error at (83,3)-(83,4011): Illegal quoting" [](start = 83, length = 95)
Can we have issue about this? it's weird exception, I don't get how change of platform can lead to change of reading data. #Resolved
There was a problem hiding this comment.
I copied this comment from the other tests in this file, I'm not sure it actually fails on x86.
@tannergooding , is there an issue for this? #Resolved
| var inputFile = new SimpleFileHandle(Env, dataPath, false, false); | ||
| #pragma warning disable 0618 | ||
| var dataView = ImportTextData.ImportText(Env, new ImportTextData.Input { InputFile = inputFile }).Data; | ||
| #pragma warning restore 0618 |
There was a problem hiding this comment.
Can we not add obsolete code?
var reader = TextLoader.CreateReader(Env, ctx => (
Features: ctx.LoadFloat(1, 8),
Label: ctx.LoadFloat(0)
));
var data = reader.Read(dataPath).AsDynamic;
``` #Resolved
| @@ -70,6 +73,12 @@ public EnsembleTrainer(IHostEnvironment env, Arguments args) | |||
| Combiner = args.OutputCombiner.CreateComponent(Host); | |||
| } | |||
|
|
|||
| public EnsembleTrainer(IHostEnvironment env, Arguments args, PredictionKind predictionKind) | |||
There was a problem hiding this comment.
public EnsembleTrainer(IHostEnvironment env, Arguments args, PredictionKind predictionKind) [](start = 6, length = 93)
in the spirit of reducing public ctor, would it make sense to add the PredictionKind as an optional param, or that would be confusing? #Resolved
There was a problem hiding this comment.
ghost
locked as resolved and limited conversation to collaborators
Fixes #1304.