Introducing official x86 CI build #1306
Conversation
artidoro
changed the title
artidoro
changed the title
|
@eerhardt, do you know what it would take to download the correct test host, so we can actually run tests during CI? |
|
@tannergooding I asked him earlier, and apparently it's just a question of downloading the .NET Core x86 SDK. And it should be done by conditionally calling init-tools.cmd with set DOTNET_ZIP_NAME=dotnet-sdk-%DOTNET_VERSION%-win-x64.zip replacing x64 with x86 depending on the architecture. I will post a second PR, as suggested by Eric, so that the changes are separated. |
build/vsts-ci.yml
Outdated
| continueOnError: false | ||
| condition: and(succeeded(), in(variables._SignType, 'real', 'test')) | ||
|
|
||
| - script: ./build.cmd -$(BuildConfig) -buildArch=x86 |
There was a problem hiding this comment.
We should only be building the native assets on the Windows_x86 leg. See the Linux and OSX legs.
script: ./build.sh -buildNative -$(BuildConfig)
The reason for this is because we don't want the IL assets to collide/conflict. Each leg needs to build a unique set of assets.
Today:
OSX: builds the OSX native assets.
Linux: builds the Linux native assets
Windows: builds Windows x64 native assets, and the managed assets.
This new leg should only be building the Windows x86 native assets.
There was a problem hiding this comment.
Thank you for pointing that out! I changed the script so that it builds native assets only on this leg.
build/vsts-ci.yml
Outdated
| inputs: | ||
| pathToPublish: $(Build.SourcesDirectory)/bin/obj/packages | ||
| artifactName: PackageAssets | ||
| artifactType: container | ||
|
|
||
| ################################################################################ | ||
| - phase: Windows_x86 |
There was a problem hiding this comment.
should this one be Windows_x64?
There was a problem hiding this comment.
Yes that's a good point, I will change the name so that it's clearer.
ghost
locked as resolved and limited conversation to collaborators
Fixes #1295.
Adding x86 official build. I tested the official build directly on VSTS and it succeeded. I also created a x86 App locally and tested that the nuget packages published to VSTS by the build worked.