-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Introducing PR verification x86 CI build #1309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We need to put conditions on TensorFlow transform tests since it's work only with x64 bits (at least from what I see from test failure).
|
Looks good so far. Just need to get the tests passing. |
{ | ||
return CheckEqualityCore(dir, name, nameBase ?? name, true, digitsOfPrecision); | ||
int precision = digitsOfPrecision ?? (Environment.Is64BitProcess ? DigitsOfPrecision_x64 : DigitsOfPrecision_x86); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems that int precision = digitsOfPrecision ?? (Environment.Is64BitProcess ? DigitsOfPrecision_x64 : DigitsOfPrecision_x86);
could be pulled out into a property like public int DigitsOfPrecision => Environment.Is64BitProcess ? DigitsOfPrecision_x64 : DigitsOfPrecision_x86;
rather than repeated #Resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found that having a different precision was not helpful, so I reverted that change. Thank you for the comment though!
In reply to: 227575101 [](ancestors = 227575101)
55734e4
to
c470cf0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@artidoro regarding the failing benchmark integration test. You can add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #1389.
This PR adds a PR verification build for x86. Starting an x86 build is not too difficult, however running tests requires downloading an x86 .NET Core SDK
Main contributions: