Fix build break #146
Merged
Fix build break #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous 2 changes conflicted. Resovling the break that happened between them.
glebuk
reviewed
May 14, 2018
| return trainerKind == TrainerKinds.SignatureBinaryClassifierTrainer; | ||
|
|
||
| if (type == typeof(Trainers.LogisticRegressor)) | ||
| if (type == typeof(Trainers.LogisticRegressionClassifier)) |
There was a problem hiding this comment.
LogisticRegressionClassifier [](start = 40, length = 28)
Thanks for the fix! #Resolved
yaeldekel
reviewed
May 14, 2018
| @@ -197,10 +197,10 @@ public static T TrainerKindApiValue<T>(TrainerKinds trainerKind) | |||
|
|
|||
| public static bool IsTrainerOfKind(Type type, TrainerKinds trainerKind) | |||
| { | |||
| if (type == typeof(Trainers.BinaryLogisticRegressor)) | |||
| if (type == typeof(Trainers.LogisticRegressionBinaryClassifier)) | |||
There was a problem hiding this comment.
LogisticRegressionBinaryClassifier [](start = 40, length = 34)
Thanks for fixing this Eric!
Actually, lines 200-204 are now not needed, they were there before only because the name for logistic classifiers didn't match the pattern of the other trainers (that the entry point names end with "Classifier" or "BinaryClassifier").
There was a problem hiding this comment.
Can you make a follow-up for that change? The goal here is to unblock the build. I don't want to add anymore risk.
eerhardt
added a commit
to eerhardt/machinelearning
that referenced
this pull request
Jul 27, 2018
The previous 2 changes conflicted. Resovling the break that happened between them.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous 2 changes conflicted. Resovling the break that happened between them.
I'll merge once green to get the build unblocked again.
/cc @TomFinley @glebuk @shauheen