Publishing nuget packages to myget feed. #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also - set the symbols expiration days default based on feedback from the .NET core-eng team. Fixes dotnet#11
Ivanidzo4ka
reviewed
May 15, 2018
| nuGetFeedType: internal | ||
| feedPublish: MachineLearning | ||
| solution: build/publish.proj | ||
| msbuildArguments: /t:PublishPackages /p:NuGetFeedUrl=$(_NuGetFeedUrl) /p:NuGetApiKey=$(dotnet-myget-org-api-key) |
There was a problem hiding this comment.
dotnet-myget-org-api-key [](start = 93, length = 24)
Is it purposely not defined, or we have some kind of hidden storage somewhere?
There was a problem hiding this comment.
it will be defined in the build defination using variable groups.
There was a problem hiding this comment.
Correct. It is already in build definition. This does make it appear a bit magical, but that's how secret variables work.
Ivanidzo4ka
reviewed
May 15, 2018
build/publish.proj
Outdated
| <PropertyGroup> | ||
| <PublishSymbolsPackage>Microsoft.SymbolUploader.Build.Task</PublishSymbolsPackage> | ||
| <EnablePublishSymbols Condition="'$(EnablePublishSymbols)'==''" >true</EnablePublishSymbols> | ||
| <NuGetPushTimeoutSeconds Condition="'$(NuGetPushTimeoutSeconds)' == ''">3600</NuGetPushTimeoutSeconds> |
There was a problem hiding this comment.
3600 [](start = 76, length = 4)
One hour looks like a lot of time considering size of packages.
There was a problem hiding this comment.
Agreed. I copied this from the core-setup repo, but looking at other places it is only 10 minutes. I'll update this.
Anipik
approved these changes
May 15, 2018
shauheen
approved these changes
May 15, 2018
eerhardt
added a commit
to eerhardt/machinelearning
that referenced
this pull request
Jul 27, 2018
* Publishing nuget packages to myget feed. Also - set the symbols expiration days default based on feedback from the .NET core-eng team. Fixes dotnet#11 * Shorten nuget push timeout to match corefx and coreclr.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11