Pass hashBits, invertHash to OneHotHashEncodingEstimator #1564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the help @feiyun0112 |
Zruty0
reviewed
Nov 7, 2018
|
Thanks! Please address the comments, and then it's good to go In reply to: 436707664 [](ancestors = 436707664) |
Zruty0
reviewed
Nov 7, 2018
|
@feiyun0112 sorry for the late review. It looks good to me now, but there are conflicts. Could you please merge with master, and then I'll merge it in? Also please mention @Zruty0 so that I don't forget again :) |
|
Hi @feiyun0112, still planning to wrap this? |
|
sorry for the late response. i have merged |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1560