Skip to content

Register assemblies in legacy predictor model #1570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 19, 2018
Merged

Register assemblies in legacy predictor model #1570

merged 9 commits into from
Nov 19, 2018

Conversation

ganik
Copy link
Member

@ganik ganik commented Nov 7, 2018

fixes #1150

@ganik ganik requested review from Zruty0, codemzs and Ivanidzo4ka and removed request for Zruty0 November 8, 2018 00:07
@@ -22,6 +21,7 @@ public class PredictionModel
internal PredictionModel(Stream stream)
{
_env = new ConsoleEnvironment();
AssemblyRegistration.RegisterAssemblies(_env);
Copy link
Contributor

@Zruty0 Zruty0 Nov 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RegisterAssemblies [](start = 33, length = 18)

do we need the same thing fir TransformModel? #Resolved

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only needed for Legacy namespace.


In reply to: 233615020 [](ancestors = 233615020)

Copy link
Contributor

@Zruty0 Zruty0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@Ivanidzo4ka Ivanidzo4ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ganik ganik merged commit 6c5677a into dotnet:master Nov 19, 2018
@ganik ganik deleted the ganik/compat branch December 20, 2018 04:24
@ghost ghost locked as resolved and limited conversation to collaborators Mar 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model Backwards Compatability
3 participants