WIP: Adding WhatTheFeature Scorer #1671
Conversation
| // <copyright company="Microsoft Corporation"> | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // </copyright> | ||
| //------------------------------------------------------------------------------ |
There was a problem hiding this comment.
please use other header. #Resolved
| using Microsoft.ML.Runtime.Internal.Internallearn; | ||
| using Microsoft.ML.Runtime.Internal.Utilities; | ||
| using Microsoft.ML.Runtime.Model; | ||
| using Float = System.Single; |
There was a problem hiding this comment.
can you remove this line, and use float in code? #Resolved
| [Argument(ArgumentType.AtMostOnce, HelpText = "Whether or not output of Features contribution in string key-value format", ShortName = "str", SortOrder = 4)] | ||
| public bool Stringify = false; | ||
|
|
||
| // REVIEW olgali(petelu): the scorer currently ignores the 'suffix' argument from the base class. It should respect it. |
There was a problem hiding this comment.
olgali(petelu) [](start = 22, length = 14)
strip aliases #Resolved
| /// The What The Feature scorer is superset of a generic scorer. | ||
| /// It outputs score columns from Generic Scorer plus for given features provides vector of corresponding feature contributions. | ||
| /// </summary> | ||
| public sealed class WhatTheFeatureScorerTransform |
There was a problem hiding this comment.
WhatTheFeatureScorerTransform [](start = 24, length = 29)
we need samples and documentation.
| // Apparently, loader signature is limited in length to 24 characters. | ||
| public const string MapperLoaderSignature = "WTFBindable"; | ||
| public const string LoaderSignature = "WTFScorer"; | ||
| public const int MaxTopBottom = 1000; |
There was a problem hiding this comment.
make them internal or private. #Resolved
| /// The What The Feature scorer is superset of a generic scorer. | ||
| /// It outputs score columns from Generic Scorer plus for given features provides vector of corresponding feature contributions. | ||
| /// </summary> | ||
| public sealed class WhatTheFeatureScorerTransform |
There was a problem hiding this comment.
WhatTheFeatureScorerTransform [](start = 24, length = 29)
This may have been considered funny at the time when this was an internal tool, but I feel we should come up with a different name for this externally.
|
|
||
| var featureGetter = input.GetGetter<TSrc>(colSrc); | ||
|
|
||
| // REVIEW olgali: WTF Scorer can do call to Sparicification\Norm routine. |
There was a problem hiding this comment.
WTF [](start = 34, length = 3)
Yeah, no. :P This is just asking for trouble. :) #Resolved
ghost
locked as resolved and limited conversation to collaborators
fixes #1644