Extend a test for adding string-array output example #1747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wschin
commented
Nov 28, 2018
Ivanidzo4ka
reviewed
Nov 28, 2018
| var nativeResult = new List<NativeResult>(result.AsEnumerable<NativeResult>(Env, false))[0]; | ||
|
|
||
| // Check the tokenization of A. Expected result is { "This", "is", "a", "good", "sentence." }. | ||
| var tokenizeA = new[] { "This", "is", "a", "good", "sentence." }; |
There was a problem hiding this comment.
tokenizeA [](start = 16, length = 9)
it's all cool and nice, but I would rather prefer you to add proper example to https://github.com/dotnet/machinelearning/tree/master/docs/samples/Microsoft.ML.Samples/Dynamic
than modifying this test.
There was a problem hiding this comment.
We still need a test to test "end-to-end" in terms of C# native data strucutre.
There was a problem hiding this comment.
There was a problem hiding this comment.
There was a problem hiding this comment.
I can but not in this PR. This PR is super low priority.
|
@Ivanidzo4ka, sure. Just change this PR's description so that #1746 will not be closed. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A partial solution to #1746. At least, one can search the code base to find an example of using strings in input and output.