Remove As methods on ColumnType.
#1864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eerhardt
requested review from
Ivanidzo4ka,
TomFinley,
yaeldekel,
singlis,
sfilipi and
Zruty0
TomFinley
reviewed
Dec 11, 2018
| return conv.GetStringConversion<T>(type); | ||
|
|
||
| bool identity; | ||
| // Second choice: if key, utilize the KeyValues metadata for that key, if it has one and is text. | ||
| if (schema.HasKeyValues(col, type.KeyCount)) | ||
| if (schema.HasKeyValues(col, keyType.KeyCount)) |
There was a problem hiding this comment.
KeyCount [](start = 49, length = 8)
Cool. Could change this to Count I think now that you've made this a key type, but not required. That would just be something not quite in the scope of the PR of course, so it's fine not to do it yet, I think.
There was a problem hiding this comment.
I think we can address this when remove KeyCount from the base ColumnType.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the following methods from ColumnType:
More PRs will be coming in this form. But this seemed like the lowest hanging fruit to start making incremental progress here.
Part of the work necessary for #1860