Skip to content

MLContext.Data.ReadFromBinary to accept IMultiStreamSource rather than Stream #2058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 8, 2019
Merged

MLContext.Data.ReadFromBinary to accept IMultiStreamSource rather than Stream #2058

merged 2 commits into from
Jan 8, 2019

Conversation

najeeb-kazmi
Copy link
Member

Fixes #2052

Ivanidzo4ka
Ivanidzo4ka approved these changes Jan 7, 2019
View reviewed changes
Copy link
Contributor

@Ivanidzo4ka Ivanidzo4ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

sfilipi
sfilipi approved these changes Jan 8, 2019
View reviewed changes
Copy link
Member

@sfilipi sfilipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

TomFinley
TomFinley approved these changes Jan 8, 2019
View reviewed changes
Copy link
Contributor

@TomFinley TomFinley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you good sir @najeeb-kazmi !

@najeeb-kazmi najeeb-kazmi merged commit c8755a2 into dotnet:master Jan 8, 2019
@najeeb-kazmi najeeb-kazmi deleted the 2052 branch January 30, 2020 01:14
@ghost ghost locked as resolved and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@codemzs codemzs Awaiting requested review from codemzs

@glebuk glebuk Awaiting requested review from glebuk

3 more reviewers

@Ivanidzo4ka Ivanidzo4ka Ivanidzo4ka approved these changes

@TomFinley TomFinley TomFinley approved these changes

@sfilipi sfilipi sfilipi approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@najeeb-kazmi @Ivanidzo4ka @TomFinley @sfilipi