Skip to content

Remove ColumnType.RawKind Round 3 (and final) #2202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 23, 2019
Merged

Remove ColumnType.RawKind Round 3 (and final) #2202

merged 5 commits into from
Jan 23, 2019

Conversation

eerhardt
Copy link
Member

@eerhardt eerhardt commented Jan 22, 2019 •
edited
Loading

Completely removes ColumnType.RawKind.

Part of the work necessary for #1860.

Fix #1533.

@zeahmed
Copy link
Contributor

zeahmed commented Jan 23, 2019 •
edited
Loading 

    /// and also the associated data kind for this type. If a data kind could not

Need to update? #Closed

Refers to: src/Microsoft.ML.Data/DataView/InternalSchemaDefinition.cs:136 in 8b83ad8. [](commit_id = 8b83ad8, deletion_comment = False)

@zeahmed
Copy link
Contributor

zeahmed commented Jan 23, 2019 •
edited
Loading 

    /// They must both be vectors or scalars, and the raw data kind should match.

Here as well? #Closed

Refers to: src/Microsoft.ML.Data/DataView/TypedCursor.cs:136 in 8b83ad8. [](commit_id = 8b83ad8, deletion_comment = False)

@eerhardt eerhardt changed the title WIP: Remove ColumnType.RawKind Round 3 (and final) Remove ColumnType.RawKind Round 3 (and final) Jan 23, 2019
@eerhardt
Copy link
Member Author

This PR is ready for review now that #2176 is merged.

TomFinley
TomFinley approved these changes Jan 23, 2019
View reviewed changes
Copy link
Contributor

@TomFinley TomFinley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm. I always get suspicious when I read through a large-ish PR and can't really find anything to comment on. 😄 Thanks @eerhardt!

zeahmed
zeahmed approved these changes Jan 23, 2019
View reviewed changes
Copy link
Contributor

@zeahmed zeahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@eerhardt eerhardt merged commit 082e3fc into dotnet:master Jan 23, 2019
@eerhardt eerhardt deleted the ColumnTypeRawKind3 branch January 23, 2019 20:40
@ghost ghost locked as resolved and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TomFinley TomFinley TomFinley approved these changes

@zeahmed zeahmed zeahmed approved these changes

@Ivanidzo4ka Ivanidzo4ka Awaiting requested review from Ivanidzo4ka

@sfilipi sfilipi Awaiting requested review from sfilipi

@yaeldekel yaeldekel Awaiting requested review from yaeldekel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eerhardt @zeahmed @TomFinley