Modify API for advanced settings (FieldAwareFactorizationMachineTrainer) #2219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wschin
reviewed
Jan 24, 2019
| s.LatentDim = 7; | ||
| }); | ||
| var ffmArgs = new FieldAwareFactorizationMachineTrainer.Options { | ||
| FeatureColumn = "Feature1", |
There was a problem hiding this comment.
Suggested change
| FeatureColumn = "Feature1", | |
| FeatureColumn = "Feature1", // Features from the 1st field. | |
| ``` #Resolved |
wschin
reviewed
Jan 24, 2019
| }); | ||
| var ffmArgs = new FieldAwareFactorizationMachineTrainer.Options { | ||
| FeatureColumn = "Feature1", | ||
| ExtraFeatureColumns = new[] { "Feature2", "Feature3", "Feature4" }, |
There was a problem hiding this comment.
Suggested change
| ExtraFeatureColumns = new[] { "Feature2", "Feature3", "Feature4" }, | |
| ExtraFeatureColumns = new[] { "Feature2", "Feature3", "Feature4" }, // 2nd field's feature column, 3rd field's feature column, 4th field's feature column.``` #Resolved |
wschin
reviewed
Jan 24, 2019
| /// <param name="onFit">A delegate that is called every time the | ||
| /// <see cref="Estimator{TInShape, TOutShape, TTransformer}.Fit(DataView{TInShape})"/> method is called on the | ||
| /// <see cref="Estimator{TInShape, TOutShape, TTransformer}"/> instance created out of this. This delegate will receive | ||
| /// the model that was trained. Note that this action cannot change the result in any way; it is only a way for the caller to |
There was a problem hiding this comment.
What's the type of the model that was trained? Is it possible to make a reference here? #Resolved
wschin
reviewed
Jan 24, 2019
| /// The settings here will override the ones provided in the direct method signature, | ||
| /// if both are present and have different values. | ||
| /// The columns names, however need to be provided directly, not through the <paramref name="advancedSettings"/>.</param>/// <param name="onFit">A delegate that is called every time the | ||
| /// <param name="onFit">A delegate that is called every time the |
There was a problem hiding this comment.
Could we reference the type of the trained model? It's impossible for user to write onFit without knowing its input type. Many thanks. #Resolved
Codecov Report
@@ Coverage Diff @@
## master #2219 +/- ##
==========================================
+ Coverage 69.78% 80.8% +11.01%
==========================================
Files 786 159 -627
Lines 143945 28504 -115441
Branches 16648 1909 -14739
==========================================
- Hits 100451 23032 -77419
+ Misses 38951 5175 -33776
+ Partials 4543 297 -4246
|
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #1798 .
This PR addresses the following algos
The following changes have been made:
publicextension methods, one for simple arguments and the other for advanced optionsinternal. Also a few other fields have been madeinternalOptionsfor API consistency.