Move IDataView to Microsoft.Data.DataView namespace. #2254
Conversation
eerhardt
requested review from
codemzs,
stephentoub,
TomFinley,
yaeldekel and
sfilipi
Codecov Report
@@ Coverage Diff @@
## master #2254 +/- ##
======================================
Coverage 80.8% 80.8%
======================================
Files 159 159
Lines 28503 28503
Branches 1910 1910
======================================
Hits 23031 23031
Misses 5175 5175
Partials 297 297
|
| @@ -18,6 +19,7 @@ | |||
| using Parquet; | |||
| using Parquet.Data; | |||
| using Parquet.File.Values.Primitives; | |||
| using DataViewSchema = Microsoft.Data.DataView.Schema; | |||
There was a problem hiding this comment.
The idea was broached I know, but resolution never reached: should we rename? Or else perhaps make Schema a nested class of something appropriate, so as to give it definition?
I guess if something as useful as the Parquet format can get away with naming something "schema" without complaint, maybe we (being, I suppose, less universally beloved for now) can get away with it as well fairly easily.
There was a problem hiding this comment.
We could rename the class to DataViewSchema, or ViewSchema.
We’d probably want to rename everything then. Row is a pretty generic name. So is ColumnType.
The Error List Window in VS, and CTRL+. -> Add Using. :( |
| diagPs.CreateDiagnosticResult(37, 13, "Class8", "F2"), | ||
| diagPg.CreateDiagnosticResult(38, 13, "Class9", "F2"), | ||
| diagPc.CreateDiagnosticResult(39, 13, "Class10"), | ||
| diagPc.CreateDiagnosticResult(40, 13, "Class11"), |
There was a problem hiding this comment.
I was scrolling thru, getting carpal tunnel, about to conclude "oh look an easy PR approval".
What are these changing in response to?
There was a problem hiding this comment.
This is our C# diagnostics analyzer test, which ensures our code analyzer gives the right warnings/errors on the correct code lines.
Because the code being analyzed used an ‘IDataView’ variable, I needed to insert a new ‘using’ statement at the top of the code. This moved all the code down one line, causing the tests to now be off by one line.
There was a problem hiding this comment.
Seems a bit hard to maintain.
ghost
locked as resolved and limited conversation to collaborators
Renaming the namespace of the IDataView types.
Follow up to #1860
I also added a few copyrights where they were missing.