Skip to content

Address minor comments in #2243 #2369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Microsoft.ML.FastTree/RegressionTree.cs
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,9 @@ public abstract class RegressionTreeBase
/// Note that the case (1) happens only when <see cref="CategoricalSplitFlags"/>[i] is true and otherwise (2)
/// occurs. A non-negative returned value means a node (i.e., not a leaf); for example, 2 means the 3rd node in
/// the underlying <see cref="_tree"/>. A negative returned value means a leaf; for example, -1 stands for the
/// first leaf in the underlying <see cref="_tree"/>.
/// <see langword="~"/>(-1)-th leaf in the underlying <see cref="_tree"/>. Note that <see langword="~"/> is the
/// bitwise complement operator in C#; for details, see
/// https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/operators/bitwise-complement-operator.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see the documentation about the bitwise complement operator

/// </summary>
public IReadOnlyList<int> LteChild => _lteChild;

Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.ML.FastTree/TreeEnsemble.cs
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public abstract class TreeEnsemble<T> where T : RegressionTreeBase
/// </summary>
public IReadOnlyList<T> Trees { get; }

internal TreeEnsemble(IEnumerable<T> trees, IEnumerable<double> treeWeights, double bias)
private protected TreeEnsemble(IEnumerable<T> trees, IEnumerable<double> treeWeights, double bias)
{
Bias = bias;
TreeWeights = treeWeights.ToList();
Expand Down