Skip to content

Towards #2326 - removing some namespaces #2442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 10, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
using System;
using System.Linq;
using Microsoft.Data.DataView;
using Microsoft.ML.Learners;
using Microsoft.ML.Data;
using Microsoft.ML.Trainers;
using Microsoft.ML.SamplesUtils;
using Microsoft.ML.Trainers.HalLearners;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
using System;
using System.Linq;
using Microsoft.ML.Learners;
using Microsoft.ML.Trainers;

namespace Microsoft.ML.Samples.Dynamic.PermutationFeatureImportance
{
Expand Down
2 changes: 1 addition & 1 deletion docs/samples/Microsoft.ML.Samples/Static/SDCARegression.cs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
using System;
using Microsoft.ML.Data;
using Microsoft.ML.Learners;
using Microsoft.ML.StaticPipe;
using Microsoft.ML.Trainers;

namespace Microsoft.ML.Samples.Static
{
Expand Down
3 changes: 1 addition & 2 deletions src/Microsoft.ML.Ensemble/EntryPoints/CreateEnsemble.cs
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,13 @@
using Microsoft.ML.CommandLine;
using Microsoft.ML.Data;
using Microsoft.ML.Ensemble;
using Microsoft.ML.Ensemble.EntryPoints;
using Microsoft.ML.Ensemble.OutputCombiners;
using Microsoft.ML.EntryPoints;
using Microsoft.ML.Internal.Utilities;

[assembly: LoadableClass(typeof(void), typeof(EnsembleCreator), null, typeof(SignatureEntryPointModule), "CreateEnsemble")]

namespace Microsoft.ML.EntryPoints
namespace Microsoft.ML.Ensemble
{
/// <summary>
/// A component to combine given models into an ensemble model.
Expand Down
4 changes: 2 additions & 2 deletions src/Microsoft.ML.Ensemble/EntryPoints/DiversityMeasure.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

using Microsoft.ML.Ensemble.EntryPoints;
using Microsoft.ML.Ensemble;
using Microsoft.ML.Ensemble.Selector;
using Microsoft.ML.Ensemble.Selector.DiversityMeasure;
using Microsoft.ML.EntryPoints;
Expand All @@ -11,7 +11,7 @@
[assembly: EntryPointModule(typeof(RegressionDisagreementDiversityFactory))]
[assembly: EntryPointModule(typeof(MultiDisagreementDiversityFactory))]

namespace Microsoft.ML.Ensemble.EntryPoints
namespace Microsoft.ML.Ensemble
{
[TlcModule.Component(Name = DisagreementDiversityMeasure.LoadName, FriendlyName = DisagreementDiversityMeasure.UserName)]
internal sealed class DisagreementDiversityFactory : ISupportBinaryDiversityMeasureFactory
Expand Down
4 changes: 2 additions & 2 deletions src/Microsoft.ML.Ensemble/EntryPoints/Ensemble.cs
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@
// See the LICENSE file in the project root for more information.

using Microsoft.ML;
using Microsoft.ML.Ensemble.EntryPoints;
using Microsoft.ML.Ensemble;
using Microsoft.ML.EntryPoints;

[assembly: LoadableClass(typeof(void), typeof(Ensemble), null, typeof(SignatureEntryPointModule), "TrainEnsemble")]

namespace Microsoft.ML.Ensemble.EntryPoints
namespace Microsoft.ML.Ensemble
{
internal static class Ensemble
{
Expand Down
4 changes: 2 additions & 2 deletions src/Microsoft.ML.Ensemble/EntryPoints/FeatureSelector.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

using Microsoft.ML.Ensemble.EntryPoints;
using Microsoft.ML.Ensemble;
using Microsoft.ML.Ensemble.Selector;
using Microsoft.ML.Ensemble.Selector.FeatureSelector;
using Microsoft.ML.EntryPoints;

[assembly: EntryPointModule(typeof(AllFeatureSelectorFactory))]
[assembly: EntryPointModule(typeof(RandomFeatureSelector))]

namespace Microsoft.ML.Ensemble.EntryPoints
namespace Microsoft.ML.Ensemble
{
[TlcModule.Component(Name = AllFeatureSelector.LoadName, FriendlyName = AllFeatureSelector.UserName)]
public sealed class AllFeatureSelectorFactory : ISupportFeatureSelectorFactory
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this belong in Ensemble?

Expand Down
4 changes: 2 additions & 2 deletions src/Microsoft.ML.Ensemble/EntryPoints/OutputCombiner.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

using Microsoft.ML.Ensemble.EntryPoints;
using Microsoft.ML.Ensemble;
using Microsoft.ML.Ensemble.OutputCombiners;
using Microsoft.ML.EntryPoints;

Expand All @@ -18,7 +18,7 @@
[assembly: EntryPointModule(typeof(VotingFactory))]
[assembly: EntryPointModule(typeof(WeightedAverage))]

namespace Microsoft.ML.Ensemble.EntryPoints
namespace Microsoft.ML.Ensemble
{
[TlcModule.Component(Name = Average.LoadName, FriendlyName = Average.UserName)]
public sealed class AverageFactory : ISupportBinaryOutputCombinerFactory, ISupportRegressionOutputCombinerFactory
Expand Down
4 changes: 2 additions & 2 deletions src/Microsoft.ML.Ensemble/EntryPoints/PipelineEnsemble.cs
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@

using Microsoft.Data.DataView;
using Microsoft.ML.Data;
using Microsoft.ML.Ensemble.EntryPoints;
using Microsoft.ML.Ensemble;
using Microsoft.ML.EntryPoints;
using Microsoft.ML.Internal.Calibration;

[assembly: EntryPointModule(typeof(PipelineEnsemble))]

namespace Microsoft.ML.Ensemble.EntryPoints
namespace Microsoft.ML.Ensemble
{
internal static class PipelineEnsemble
{
Expand Down
4 changes: 2 additions & 2 deletions src/Microsoft.ML.Ensemble/EntryPoints/SubModelSelector.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

using Microsoft.ML.Ensemble.EntryPoints;
using Microsoft.ML.Ensemble;
using Microsoft.ML.Ensemble.Selector;
using Microsoft.ML.Ensemble.Selector.SubModelSelector;
using Microsoft.ML.EntryPoints;
Expand All @@ -16,7 +16,7 @@
[assembly: EntryPointModule(typeof(BestPerformanceSelector))]
[assembly: EntryPointModule(typeof(BestPerformanceSelectorMultiClass))]

namespace Microsoft.ML.Ensemble.EntryPoints
namespace Microsoft.ML.Ensemble
{
[TlcModule.Component(Name = AllSelector.LoadName, FriendlyName = AllSelector.UserName)]
public sealed class AllSelectorFactory : ISupportBinarySubModelSelectorFactory, ISupportRegressionSubModelSelectorFactory
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
using System.Collections.Generic;
using Microsoft.ML;
using Microsoft.ML.CommandLine;
using Microsoft.ML.Ensemble.EntryPoints;
using Microsoft.ML.Ensemble.Selector;
using Microsoft.ML.Ensemble.Selector.DiversityMeasure;
using Microsoft.ML.Ensemble.Selector.SubModelSelector;
Expand All @@ -19,8 +18,6 @@

namespace Microsoft.ML.Ensemble.Selector.SubModelSelector
{
using TScalarPredictor = IPredictorProducing<Single>;

internal sealed class BestDiverseSelectorBinary : BaseDiverseSelector<Single, DisagreementDiversityMeasure>, IBinarySubModelSelector
{
public const string UserName = "Best Diverse Selector";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
using Microsoft.ML;
using Microsoft.ML.CommandLine;
using Microsoft.ML.Data;
using Microsoft.ML.Ensemble.EntryPoints;
using Microsoft.ML.Ensemble.Selector;
using Microsoft.ML.Ensemble.Selector.DiversityMeasure;
using Microsoft.ML.Ensemble.Selector.SubModelSelector;
Expand All @@ -20,8 +19,6 @@

namespace Microsoft.ML.Ensemble.Selector.SubModelSelector
{
using TVectorPredictor = IPredictorProducing<VBuffer<Single>>;

internal sealed class BestDiverseSelectorMultiClass : BaseDiverseSelector<VBuffer<Single>, IDiversityMeasure<VBuffer<Single>>>, IMulticlassSubModelSelector
{
public const string UserName = "Best Diverse Selector";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
using System.Collections.Generic;
using Microsoft.ML;
using Microsoft.ML.CommandLine;
using Microsoft.ML.Ensemble.EntryPoints;
using Microsoft.ML.Ensemble.Selector;
using Microsoft.ML.Ensemble.Selector.DiversityMeasure;
using Microsoft.ML.Ensemble.Selector.SubModelSelector;
Expand All @@ -19,8 +18,6 @@

namespace Microsoft.ML.Ensemble.Selector.SubModelSelector
{
using TScalarPredictor = IPredictorProducing<Single>;

internal sealed class BestDiverseSelectorRegression : BaseDiverseSelector<Single, RegressionDisagreementDiversityMeasure>, IRegressionSubModelSelector
{
public const string UserName = "Best Diverse Selector";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
using System.Collections.Generic;
using Microsoft.ML.CommandLine;
using Microsoft.ML.Data;
using Microsoft.ML.Ensemble.EntryPoints;
using Microsoft.ML.Transforms;

namespace Microsoft.ML.Ensemble.Selector.SubsetSelector
Expand Down
3 changes: 1 addition & 2 deletions src/Microsoft.ML.Ensemble/Trainer/Binary/EnsembleTrainer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,10 @@
using Microsoft.ML;
using Microsoft.ML.CommandLine;
using Microsoft.ML.Ensemble;
using Microsoft.ML.Ensemble.EntryPoints;
using Microsoft.ML.Ensemble.OutputCombiners;
using Microsoft.ML.Ensemble.Selector;
using Microsoft.ML.Internal.Internallearn;
using Microsoft.ML.Learners;
using Microsoft.ML.Trainers;
using Microsoft.ML.Trainers.Online;
using Microsoft.ML.Training;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,10 @@
using Microsoft.ML.CommandLine;
using Microsoft.ML.Data;
using Microsoft.ML.Ensemble;
using Microsoft.ML.Ensemble.EntryPoints;
using Microsoft.ML.Ensemble.OutputCombiners;
using Microsoft.ML.Ensemble.Selector;
using Microsoft.ML.Internal.Internallearn;
using Microsoft.ML.Learners;
using Microsoft.ML.Trainers;
using Microsoft.ML.Training;

[assembly: LoadableClass(MulticlassDataPartitionEnsembleTrainer.Summary, typeof(MulticlassDataPartitionEnsembleTrainer),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,11 @@
using System.Linq;
using Microsoft.ML;
using Microsoft.ML.CommandLine;
using Microsoft.ML.Data;
using Microsoft.ML.Ensemble;
using Microsoft.ML.Ensemble.EntryPoints;
using Microsoft.ML.Ensemble.OutputCombiners;
using Microsoft.ML.Ensemble.Selector;
using Microsoft.ML.Internal.Internallearn;
using Microsoft.ML.Learners;
using Microsoft.ML.Trainers;
using Microsoft.ML.Trainers.Online;
using Microsoft.ML.Training;

Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.ML.FastTree/BinFile/BinFinder.cs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
using Microsoft.ML.Data;
using Microsoft.ML.Internal.Utilities;

namespace Microsoft.ML.Trainers.FastTree.Internal
namespace Microsoft.ML.Trainers.FastTree
{
/// <summary>
/// A class that bins vectors of doubles into a specified number of equal mass bins.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
using System.Runtime.InteropServices;
using System.Text;

namespace Microsoft.ML.Trainers.FastTree.Internal
namespace Microsoft.ML.Trainers.FastTree
{
internal sealed class IniFileParserInterface
{
Expand Down
1 change: 0 additions & 1 deletion src/Microsoft.ML.FastTree/BoostingFastTree.cs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
using System.Linq;
using Microsoft.ML.Core.Data;
using Microsoft.ML.Internal.Internallearn;
using Microsoft.ML.Trainers.FastTree.Internal;
using Float = System.Single;

namespace Microsoft.ML.Trainers.FastTree
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.ML.FastTree/Dataset/Dataset.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
using System.Threading.Tasks;
using Microsoft.ML.Internal.Utilities;

namespace Microsoft.ML.Trainers.FastTree.Internal
namespace Microsoft.ML.Trainers.FastTree
{
/// <summary>
/// A dataset of features.
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.ML.FastTree/Dataset/DatasetUtils.cs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
using System.Collections.Generic;
using System.Linq;

namespace Microsoft.ML.Trainers.FastTree.Internal
namespace Microsoft.ML.Trainers.FastTree
{
/// <summary>
/// Loads training/validation/test sets from file
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.ML.FastTree/Dataset/DenseIntArray.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
using System.Runtime.InteropServices;
using System.Security;

namespace Microsoft.ML.Trainers.FastTree.Internal
namespace Microsoft.ML.Trainers.FastTree
{
#if USE_SINGLE_PRECISION
using FloatType = System.Single;
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.ML.FastTree/Dataset/Feature.cs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

using System.Linq;

namespace Microsoft.ML.Trainers.FastTree.Internal
namespace Microsoft.ML.Trainers.FastTree
{

/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.ML.FastTree/Dataset/FeatureFlock.cs
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
using Microsoft.ML.Internal.CpuMath;
using Microsoft.ML.Internal.Utilities;

namespace Microsoft.ML.Trainers.FastTree.Internal
namespace Microsoft.ML.Trainers.FastTree
{
/// <summary>
/// Holds statistics per bin value for a feature. These are yielded by <see cref="SufficientStatsBase.GetBinStats"/>
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.ML.FastTree/Dataset/FeatureHistogram.cs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
using System;
using System.Linq;

namespace Microsoft.ML.Trainers.FastTree.Internal
namespace Microsoft.ML.Trainers.FastTree
{
#if USE_SINGLE_PRECISION
using FloatType = System.Single;
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.ML.FastTree/Dataset/FileObjectStore.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

namespace Microsoft.ML.Trainers.FastTree.Internal
namespace Microsoft.ML.Trainers.FastTree
{
#if !NO_STORE
/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.ML.FastTree/Dataset/IntArray.cs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
using System.Collections.Generic;
using System.Linq;

namespace Microsoft.ML.Trainers.FastTree.Internal
namespace Microsoft.ML.Trainers.FastTree
{
#if USE_SINGLE_PRECISION
using FloatType = System.Single;
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.ML.FastTree/Dataset/NHotFeatureFlock.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

namespace Microsoft.ML.Trainers.FastTree.Internal
namespace Microsoft.ML.Trainers.FastTree
{
/// <summary>
/// This is a feature flock that misuses a property of <see cref="DeltaSparseIntArray.Sumup"/>
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.ML.FastTree/Dataset/OneHotFeatureFlock.cs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

using System.Linq;

namespace Microsoft.ML.Trainers.FastTree.Internal
namespace Microsoft.ML.Trainers.FastTree
{
/// <summary>
/// A feature flock for a set of features where per example at most one of the features has a
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.ML.FastTree/Dataset/RepeatIntArray.cs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
using System.Collections.Generic;
using System.Linq;

namespace Microsoft.ML.Trainers.FastTree.Internal
namespace Microsoft.ML.Trainers.FastTree
{
#if USE_SINGLE_PRECISION
using FloatType = Single;
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.ML.FastTree/Dataset/SegmentIntArray.cs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
using System.Runtime.InteropServices;
using System.Security;

namespace Microsoft.ML.Trainers.FastTree.Internal
namespace Microsoft.ML.Trainers.FastTree
{
#if USE_SINGLE_PRECISION
using FloatType = System.Single;
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.ML.FastTree/Dataset/SingletonFeatureFlock.cs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
using System.Linq;
using Microsoft.ML.Internal.Utilities;

namespace Microsoft.ML.Trainers.FastTree.Internal
namespace Microsoft.ML.Trainers.FastTree
{
/// <summary>
/// The singleton feature flock is the simplest possible sort of flock, that is, a flock
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.ML.FastTree/Dataset/SparseIntArray.cs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
using System.Runtime.InteropServices;
using System.Security;

namespace Microsoft.ML.Trainers.FastTree.Internal
namespace Microsoft.ML.Trainers.FastTree
{
#if USE_SINGLE_PRECISION
using FloatType = System.Single;
Expand Down
Loading